feat(e2e): add permission-based project dashboard tests

- Add writer permission override option to ApiMockHelper.setupProjectSlugMock()
- Add comprehensive tests for users without write permissions
- Add writer property to mock project data for permission testing
- Restructure tests with permission-based describe blocks
- Fix GitHub Actions e2e workflow to use exit codes instead of .last-run.json
- Test Quick Actions menu visibility based on permissions
- Test empty state buttons (Create Meeting, Add Committee) are hidden for read-only
- Test read-only users can still access all view-only functionality
- Test responsive design for read-only users

🤖 Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Asitha de Silva <asithade@gmail.com>

Author: asithade

.github/workflows/e2e-tests.yml

@@ -244,32 +244,40 @@ jobs:
         run: yarn build
 
       - name: Run E2E tests (All browsers)
+        id: run-tests-all
         if: ${{ inputs.browser == 'all' && steps.validate-secrets.outputs.can_run_tests == 'true' }}
         working-directory: apps/lfx-pcc
+        continue-on-error: true
         run: |
           if [ -n "$TEST_USERNAME" ] && [ -n "$TEST_PASSWORD" ]; then
             echo "🔐 Running authenticated E2E tests on all browsers"
             echo "🚀 Playwright will automatically start the dev server on localhost:4200"
             echo "📋 Using secrets from AWS Secrets Manager"
             yarn ${{ inputs.test-command }} --reporter=list
+            echo "test_exit_code=$?" >> $GITHUB_OUTPUT
           else
             echo "⚠️ No test credentials provided. Skipping E2E tests."
             echo "Set TEST_USERNAME and TEST_PASSWORD secrets to enable E2E tests."
+            echo "test_exit_code=0" >> $GITHUB_OUTPUT
             exit 0
           fi
 
       - name: Run E2E tests (Specific browser)
+        id: run-tests-specific
         if: ${{ inputs.browser != 'all' && steps.validate-secrets.outputs.can_run_tests == 'true' }}
         working-directory: apps/lfx-pcc
+        continue-on-error: true
         run: |
           if [ -n "$TEST_USERNAME" ] && [ -n "$TEST_PASSWORD" ]; then
             echo "🔐 Running authenticated E2E tests on ${{ inputs.browser }}"
             echo "🚀 Playwright will automatically start the dev server on localhost:4200"
             echo "📋 Using secrets from AWS Secrets Manager"
             yarn ${{ inputs.test-command }} --project=${{ inputs.browser }} --reporter=list
+            echo "test_exit_code=$?" >> $GITHUB_OUTPUT
           else
             echo "⚠️ No test credentials provided. Skipping E2E tests."
             echo "Set TEST_USERNAME and TEST_PASSWORD secrets to enable E2E tests."
+            echo "test_exit_code=0" >> $GITHUB_OUTPUT
             exit 0
           fi
 
@@ -299,12 +307,25 @@ jobs:
           elif [ -z "$TEST_USERNAME" ] || [ -z "$TEST_PASSWORD" ]; then
             echo "⏭️ E2E tests skipped (no test credentials)"
             echo "results=skipped" >> $GITHUB_OUTPUT
-          elif [ -f "test-results/.last-run.json" ]; then
-            echo "✅ E2E tests completed successfully"
-            echo "results=success" >> $GITHUB_OUTPUT
           else
-            echo "❌ E2E tests failed"
-            echo "results=failure" >> $GITHUB_OUTPUT
+            # Check exit codes from test execution steps
+            ALL_EXIT_CODE="${{ steps.run-tests-all.outputs.test_exit_code }}"
+            SPECIFIC_EXIT_CODE="${{ steps.run-tests-specific.outputs.test_exit_code }}"
+            
+            # Determine which test was run and check its exit code
+            if [ "${{ inputs.browser }}" == "all" ]; then
+              EXIT_CODE="$ALL_EXIT_CODE"
+            else
+              EXIT_CODE="$SPECIFIC_EXIT_CODE"
+            fi
+            
+            if [ "$EXIT_CODE" == "0" ]; then
+              echo "✅ E2E tests completed successfully"
+              echo "results=success" >> $GITHUB_OUTPUT
+            else
+              echo "❌ E2E tests failed (exit code: $EXIT_CODE)"
+              echo "results=failure" >> $GITHUB_OUTPUT
+            fi
           fi
 
       - name: Comment test results on PR

apps/lfx-pcc/e2e/fixtures/mock-data/projects.mock.ts

@@ -33,6 +33,7 @@ export const mockProjects: Record<string, Project> = {
     committees_count: 5,
     meetings_count: 23,
     mailing_list_count: 8,
+    writer: true,
   },
   cncf: {
     uid: 'b09f1234-f567-4abc-b890-1234567890bc',
@@ -59,6 +60,7 @@ export const mockProjects: Record<string, Project> = {
     committees_count: 12,
     meetings_count: 156,
     mailing_list_count: 25,
+    writer: false,
   },
   kubernetes: {
     uid: 'c09f1234-f567-4abc-b890-1234567890cd',
@@ -84,6 +86,7 @@ export const mockProjects: Record<string, Project> = {
     committees_count: 8,
     meetings_count: 89,
     mailing_list_count: 15,
+    writer: false,
   },
 };
 

apps/lfx-pcc/e2e/helpers/api-mock.helper.ts

@@ -13,8 +13,10 @@ export class ApiMockHelper {
   /**
    * Setup mock for the project slug endpoint only
    * @param page - Playwright page instance
+   * @param options - Optional configuration for the mock
+   * @param options.writer - Override the writer permission for the project
    */
-  static async setupProjectSlugMock(page: Page): Promise<void> {
+  static async setupProjectSlugMock(page: Page, options?: { writer?: boolean }): Promise<void> {
     // Mock individual project by slug endpoint (/api/projects/:slug)
     await page.route('**/api/projects/*', async (route) => {
       const url = route.request().url();
@@ -44,10 +46,16 @@ export class ApiMockHelper {
         return;
       }
 
+      // Apply writer permission override if provided
+      let finalProject = project;
+      if (options?.writer !== undefined) {
+        finalProject = { ...project, writer: options.writer };
+      }
+
       await route.fulfill({
         status: 200,
         contentType: 'application/json',
-        body: JSON.stringify(project),
+        body: JSON.stringify(finalProject),
       });
     });
   }