Commit bb81511
authored
feat(meetings): add meeting rsvp functionality with dynamic count calculation (#135)
* feat(meetings): add rsvp functionality with dynamic count calculation
Add comprehensive RSVP support for meetings with the following features:
- RSVP buttons (Yes/Maybe/No) in meeting cards with visual state
- Scope selection modal for recurring meetings (this/all/following)
- Dynamic RSVP count calculation respecting scope rules and recency
- Backend endpoints for creating and fetching RSVPs
- RSVP calculator utility handling occurrence-specific logic
- Token-based user identification (backend derives user from bearer token)
The RSVP system correctly handles:
- Non-recurring meetings with simple scope
- Recurring meetings with occurrence-specific RSVPs
- Precedence by most recent applicable RSVP per user
- Scope types: 'this' (single), 'all' (entire series), 'following' (future)
Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* refactor(meetings): improve rsvp implementation with signal-based approach
- Convert RSVP loading from effects to signal-based reactive streams
- Add occurrence_id field to MeetingRsvp interface for proper typing
- Improve RSVP matching logic with case-insensitive comparison
- Add RSVP refresh coordination across occurrence cards
- Display meeting context in RSVP scope modal
- Change RsvpScope from 'this' to 'single' for clarity
- Fix nested ternary expression for better readability
- Remove debug console.log statements
- Add username validation in getUserMeetingRsvp
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* fix(meetings): use occurrence-scoped skip for rsvp refresh
- Change skip logic from meetingUid to composite key (meetingUid:occurrenceId)
- Fix RSVP refresh to only skip the specific occurrence that was clicked
- Update event payload to include occurrenceId
- Fix rsvpFetchTrigger to return structured data instead of string concatenation
- Prevent UUID corruption from hyphen-based string splitting
This ensures all occurrence cards properly update their RSVP status when
scope is "all" or "following", except the specific occurrence that was
just clicked.
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* refactor(meetings): consolidate rsvp interfaces and constants to shared package
- Move RsvpScopeOption interface to shared package for reusability
- Move RsvpCounts interface to shared package interfaces
- Add RSVP_SCOPE_OPTIONS constant to shared package constants
- Update RSVP scope modal to use shared constants and interfaces
- Update dashboard meeting card to use ngClass for RSVP buttons
- Add pipe(take(1)) to dialog close subscription to prevent memory leaks
- Remove unnecessary DialogService provider from dashboard meeting card
- Simplify skip refresh key logic in my-meetings component
- Fix max-len linting error in meeting-registrants component
- Update registrant card to use ngClass for icon styling
- Improve type safety with proper RsvpResponse type annotation
Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* feat(meetings): add include_rsvp query parameter to optimize registrant fetching
- Add optional include_rsvp query parameter to GET /meetings/:uid/registrants endpoint
- Backend service fetches and attaches RSVP data when include_rsvp=true
- Add optional rsvp field to MeetingRegistrant interface
- Optimize meeting-registrants component to use single API call with include_rsvp=true
- Remove forkJoin pattern and complex RSVP matching logic from frontend
- Reduce code complexity by ~70 lines in meeting-registrants component
- Improve performance by reducing network requests from 2 to 1
- Update frontend service to accept includeRsvp parameter (defaults to false)
- Add comprehensive error handling and logging for RSVP fetching
- Maintain backward compatibility with existing API consumers
Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* refactor(dashboards): remove RSVP submission UI from dashboard
Remove the ability to submit RSVPs directly from the dashboard meeting cards.
This functionality will be refactored and reimplemented in a future iteration.
Changes:
- Remove RSVP buttons (Yes/Maybe/No) from dashboard meeting cards
- Delete RSVP scope modal component
- Remove RSVP submission handlers and refresh logic
- Clean up unused inputs (refreshTrigger, skipRefreshKey)
- Remove isRecurringMeeting computed signal
- Add update:current_user_metadata scope for future user profile updates
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* refactor(dashboards): remove RSVP submission UI from dashboard
Remove the ability to submit RSVPs directly from the dashboard meeting cards.
This functionality will be refactored and reimplemented in a future iteration.
Changes:
- Remove RSVP buttons (Yes/Maybe/No) from dashboard meeting cards
- Delete RSVP scope modal component
- Remove RSVP submission handlers and refresh logic
- Clean up unused inputs (refreshTrigger, skipRefreshKey)
- Remove isRecurringMeeting computed signal
- Add update:current_user_metadata scope for future user profile updates
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
* Remove some more unused variables
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
---------
Signed-off-by: Andres Tobon <andrest2455@gmail.com>1 parent 2a98ab7 commit bb81511
File tree
8 files changed
+541
-17
lines changed- apps/lfx-one/src
- app
- modules/project/meetings/components/meeting-registrants
- server
- controllers
- routes
- services
8 files changed
+541
-17
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
| 303 | + | |
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
304 | 306 | | |
305 | 307 | | |
306 | 308 | | |
307 | | - | |
308 | | - | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
309 | 312 | | |
310 | 313 | | |
311 | 314 | | |
| |||
438 | 441 | | |
439 | 442 | | |
440 | 443 | | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
441 | 472 | | |
442 | 473 | | |
443 | 474 | | |
| |||
Lines changed: 139 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
289 | 290 | | |
290 | 291 | | |
291 | 292 | | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
292 | 296 | | |
293 | 297 | | |
| 298 | + | |
294 | 299 | | |
295 | 300 | | |
296 | 301 | | |
| |||
306 | 311 | | |
307 | 312 | | |
308 | 313 | | |
309 | | - | |
| 314 | + | |
310 | 315 | | |
311 | 316 | | |
312 | 317 | | |
313 | 318 | | |
| 319 | + | |
314 | 320 | | |
315 | 321 | | |
316 | 322 | | |
| |||
319 | 325 | | |
320 | 326 | | |
321 | 327 | | |
| 328 | + | |
322 | 329 | | |
323 | 330 | | |
324 | 331 | | |
| |||
723 | 730 | | |
724 | 731 | | |
725 | 732 | | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
726 | 864 | | |
727 | 865 | | |
728 | 866 | | |
| |||
779 | 917 | | |
780 | 918 | | |
781 | 919 | | |
782 | | - | |
783 | | - | |
784 | | - | |
785 | 920 | | |
786 | 921 | | |
787 | 922 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| |||
0 commit comments