Skip to content

Commit 8955ff0

Browse files
committed
fix(ui): query service tag filtering
Signed-off-by: Asitha de Silva <asithade@gmail.com>
1 parent 95953ea commit 8955ff0

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

apps/lfx-pcc/src/app/shared/services/meeting.service.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ export class MeetingService {
3939
}
4040

4141
public getMeetingsByProject(projectId: string, limit?: number, orderBy?: string): Observable<Meeting[]> {
42-
// TODO: Replace tags with parent when API supports it
43-
let params = new HttpParams().set('tags', `${projectId}`);
42+
let params = new HttpParams().set('tags', `project_uid:${projectId}`);
4443

4544
if (limit) {
4645
params = params.set('limit', limit.toString());
@@ -58,10 +57,9 @@ export class MeetingService {
5857
}
5958

6059
public getUpcomingMeetingsByProject(projectId: string, limit: number = 3): Observable<Meeting[]> {
61-
// TODO: Replace tags with parent when API supports it
62-
// TODO: Replace start_time_gte with start_time_gte when API supports it
63-
let params = new HttpParams().set('tags', `${projectId}`);
60+
let params = new HttpParams().set('tags', `project_uid:${projectId}`);
6461

62+
// TODO: Add filter for upcoming meetings
6563
if (limit) {
6664
params = params.set('limit', limit.toString());
6765
}
@@ -70,10 +68,9 @@ export class MeetingService {
7068
}
7169

7270
public getPastMeetingsByProject(projectId: string, limit: number = 3): Observable<Meeting[]> {
73-
// TODO: Create new past meetings endpoint when new indexer is added
74-
// TODO: Replace tags with parent when API supports it
75-
let params = new HttpParams().set('tags', `${projectId}`);
71+
let params = new HttpParams().set('tags', `project_uid:${projectId}`);
7672

73+
// TODO: Add filter for past meetings
7774
if (limit) {
7875
params = params.set('limit', limit.toString());
7976
}

apps/lfx-pcc/src/server/services/meeting.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export class MeetingService {
5656
public async getMeetingById(req: Request, meetingUid: string): Promise<Meeting> {
5757
const params = {
5858
type: 'meeting',
59-
tags: meetingUid,
59+
tags: `meeting_uid:${meetingUid}`,
6060
};
6161

6262
const { resources } = await this.microserviceProxy.proxyRequest<QueryServiceResponse<Meeting>>(req, 'LFX_V2_SERVICE', '/query/resources', 'GET', params);

0 commit comments

Comments
 (0)