fix(profile): cleanup type improvements and comments

LFXV2-633 LFXV2-636 LFXV2-637

- Remove outdated field mapping comments from profile-edit component
- Add proper type imports for ProfileUpdateRequest and UserMetadata
- Fix error message accuracy (Username vs User ID)
- Replace any type with proper UserMetadata type in validation

🤖 Generated with [Claude Code](https://claude.ai/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Asitha de Silva <asithade@gmail.com>

Author: asithade

apps/lfx-one/src/app/modules/profile/edit/profile-edit.component.ts

@@ -221,12 +221,9 @@ export class ProfileEditComponent implements OnInit {
     const countryValue = profile.profile?.country || '';
 
     this.profileForm.patchValue({
-      // User fields - map from old backend response to new form field names
       given_name: profile.user.first_name || '',
       family_name: profile.user.last_name || '',
       username: profile.user.username || '',
-
-      // Profile fields - map from old backend response to new form field names
       job_title: profile.profile?.job_title || '',
       organization: profile.profile?.organization || '',
       country: countryValue,

apps/lfx-one/src/server/controllers/profile.controller.ts

@@ -1,7 +1,7 @@
 // Copyright The Linux Foundation and each contributor to LFX.
 // SPDX-License-Identifier: MIT
 
-import { AddEmailRequest, CombinedProfile, UpdateEmailPreferencesRequest, UserMetadataUpdateRequest } from '@lfx-one/shared/interfaces';
+import { AddEmailRequest, CombinedProfile, ProfileUpdateRequest, UpdateEmailPreferencesRequest, UserMetadataUpdateRequest } from '@lfx-one/shared/interfaces';
 import { NextFunction, Request, Response } from 'express';
 
 import { AuthenticationError, AuthorizationError, MicroserviceError, ResourceNotFoundError, ServiceValidationError } from '../errors';
@@ -123,7 +123,7 @@ export class ProfileController {
       }
 
       // Extract and validate request body
-      const { user_metadata } = req.body;
+      const { user_metadata }: ProfileUpdateRequest = req.body;
 
       // Validate at least one field to update is provided
       if (!user_metadata) {

apps/lfx-one/src/server/services/user.service.ts

@@ -3,7 +3,7 @@
 
 import { NATS_CONFIG } from '@lfx-one/shared/constants';
 import { NatsSubjects } from '@lfx-one/shared/enums';
-import { UserMetadataUpdateRequest, UserMetadataUpdateResponse } from '@lfx-one/shared/interfaces';
+import { UserMetadata, UserMetadataUpdateRequest, UserMetadataUpdateResponse } from '@lfx-one/shared/interfaces';
 import { Request } from 'express';
 
 import { serverLogger } from '../server';
@@ -22,16 +22,14 @@ export class UserService {
   /**
    * Update user metadata through NATS
    * @param req - Express request object
-   * @param userId - The user ID to update
    * @param updates - The user metadata updates
-   * @param token - Authentication token
    * @returns Promise with the update response
    */
   public async updateUserMetadata(req: Request, updates: UserMetadataUpdateRequest): Promise<UserMetadataUpdateResponse> {
     try {
       // Validate required fields
       if (!updates.username) {
-        throw new Error('User ID is required');
+        throw new Error('Username is required');
       }
 
       if (!updates.token) {
@@ -96,7 +94,7 @@ export class UserService {
    * @param metadata - The user metadata to validate
    * @returns true if valid, throws error if invalid
    */
-  public validateUserMetadata(metadata: any): boolean {
+  public validateUserMetadata(metadata: UserMetadata): boolean {
     // Validate t-shirt size if provided
     if (metadata?.t_shirt_size) {
       const validSizes = ['XS', 'S', 'M', 'L', 'XL', 'XXL', 'XXXL'];