fix(meeting-join): prevent infinite auto-join loop and ensure new tab opening

- Remove isJoining() dependency from auto-join effect to prevent re-triggering
- Eliminate hasAutoJoined flag resets that caused infinite loops
- Remove popup blocker detection and toast notifications
- Ensure all join buttons use click handler for consistent new tab behavior
- Simplify openMeetingSecurely method for reliable URL opening

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>

Author: 2 people

apps/lfx-one/src/app/modules/meeting/meeting-join/meeting-join.component.html

@@ -232,25 +232,14 @@ <h4 class="font-medium text-gray-900 font-sans">{{ user.name }}</h4>
                         }
                       </div>
                       <div class="ml-4">
-                        @if (meeting().join_url) {
-                          <lfx-button
-                            size="small"
-                            [href]="canJoinMeeting() ? joinUrlWithParams() : undefined"
-                            [disabled]="!canJoinMeeting()"
-                            severity="primary"
-                            label="Join Meeting"
-                            icon="fa-light fa-sign-in"
-                            [attr.data-testid]="'join-meeting-button-authenticated'"></lfx-button>
-                        } @else {
-                          <lfx-button
-                            size="small"
-                            severity="primary"
-                            label="Join Meeting"
-                            [disabled]="!canJoinMeeting()"
-                            icon="fa-light fa-sign-in"
-                            [attr.data-testid]="'join-meeting-button-authenticated'"
-                            (click)="onJoinMeeting()"></lfx-button>
-                        }
+                        <lfx-button
+                          size="small"
+                          severity="primary"
+                          label="Join Meeting"
+                          [disabled]="!canJoinMeeting()"
+                          icon="fa-light fa-sign-in"
+                          [attr.data-testid]="'join-meeting-button-authenticated'"
+                          (click)="onJoinMeeting()"></lfx-button>
                       </div>
                     </div>
                   </ng-template>
@@ -343,25 +332,14 @@ <h4 class="font-medium text-gray-900 font-sans">Enter your information</h4>
                         </div>
                       }
                       <div class="flex items-center">
-                        @if (meeting().join_url) {
-                          <lfx-button
-                            size="small"
-                            [href]="joinForm.invalid || !canJoinMeeting() ? undefined : joinUrlWithParams()"
-                            severity="primary"
-                            label="Join Meeting"
-                            icon="fa-light fa-sign-in"
-                            [disabled]="joinForm.invalid || !canJoinMeeting()"
-                            [attr.data-testid]="'join-meeting-button-form'"></lfx-button>
-                        } @else {
-                          <lfx-button
-                            size="small"
-                            severity="primary"
-                            label="Join Meeting"
-                            [disabled]="joinForm.invalid || !canJoinMeeting()"
-                            icon="fa-light fa-sign-in"
-                            [attr.data-testid]="'join-meeting-button-form'"
-                            (click)="onJoinMeeting()"></lfx-button>
-                        }
+                        <lfx-button
+                          size="small"
+                          severity="primary"
+                          label="Join Meeting"
+                          [disabled]="joinForm.invalid || !canJoinMeeting()"
+                          icon="fa-light fa-sign-in"
+                          [attr.data-testid]="'join-meeting-button-form'"
+                          (click)="onJoinMeeting()"></lfx-button>
                       </div>
                     </div>
                   </form>

apps/lfx-one/src/app/modules/meeting/meeting-join/meeting-join.component.ts

@@ -110,7 +110,7 @@ export class MeetingJoinComponent implements OnDestroy {
         }
 
         // Schedule auto-join only if conditions are met
-        if (authenticated && user && user.email && canJoinMeeting && !hasAutoJoined && meeting && meeting.uid && !this.isJoining()) {
+        if (authenticated && user && user.email && canJoinMeeting && !hasAutoJoined && meeting && meeting.uid) {
           // Set a timeout to prevent rapid-fire execution
           this.autoJoinTimeout = setTimeout(() => {
             this.performAutoJoin();
@@ -166,7 +166,7 @@ export class MeetingJoinComponent implements OnDestroy {
     const hasAutoJoined = this.hasAutoJoined();
     const meeting = this.meeting();
 
-    if (!authenticated || !user || !user.email || !canJoinMeeting || hasAutoJoined || !meeting || !meeting.uid || this.isJoining()) {
+    if (!authenticated || !user || !user.email || !canJoinMeeting || hasAutoJoined || !meeting || !meeting.uid) {
       return; // Conditions no longer met, abort
     }
 
@@ -210,8 +210,7 @@ export class MeetingJoinComponent implements OnDestroy {
               detail: 'Could not automatically join the meeting. Please use the Join Meeting button.',
               life: 5000,
             });
-            // Reset auto-join flag so user can try manually
-            this.hasAutoJoined.set(false);
+            // Don't reset auto-join flag - we should only try once automatically
           },
         });
     }
@@ -435,23 +434,16 @@ export class MeetingJoinComponent implements OnDestroy {
   }
 
   private openMeetingSecurely(url: string): void {
+    // Check if we're running in the browser (not SSR)
+    if (typeof window === 'undefined') {
+      return;
+    }
+
     // Try to open the meeting URL securely
     const newWindow = window.open(url, '_blank', 'noopener,noreferrer');
 
-    // Handle popup blocker scenarios
-    if (!newWindow || newWindow.closed || typeof newWindow.closed === 'undefined') {
-      // Popup was blocked, show user message with manual link
-      this.messageService.add({
-        severity: 'warn',
-        summary: 'Popup Blocked',
-        detail: 'Your browser blocked the meeting popup. Please allow popups for this site and try again, or click the Join Meeting button.',
-        life: 8000,
-      });
-
-      // Reset auto-join flag so user can try manually
-      this.hasAutoJoined.set(false);
-    } else {
-      // Clear opener reference for security (prevent tabnabbing)
+    // Clear opener reference for security (prevent tabnabbing)
+    if (newWindow) {
       newWindow.opener = null;
     }
   }