-
Notifications
You must be signed in to change notification settings - Fork 4
Add v1_sync_helper client #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughHelm chart version bumped from 0.3.10 to 0.3.11. A new Authelia client configuration for v1_sync_helper (LFX Data Backfill Service) is added to values.yaml with client_credentials grant type, one_factor authorization policy, and client_secret_basic authentication, and registered in the client generation list. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-29T16:53:12.710ZApplied to files:
🔇 Additional comments (3)
Comment |
4650326 to
d46bdf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new machine-to-machine Authelia client (v1_sync_helper) for the LFX Data Backfill Service, which will be used by the v1-sync-helper service as a fallback authentication principal when there's no relevant user to impersonate for data updates.
Key Changes:
- Added new
v1_sync_helperAuthelia client with client_credentials grant type for service authentication - Included
v1_sync_helperin the authelia_client_generation list for secret generation - Bumped chart version from 0.3.10 to 0.3.11 and updated Chart.lock dependencies
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/lfx-platform/values.yaml | Adds v1_sync_helper client configuration following M2M authentication patterns and includes it in client generation list |
| charts/lfx-platform/Chart.yaml | Bumps chart version to 0.3.11 to reflect the new client addition |
| charts/lfx-platform/Chart.lock | Updates dependency lock file with new digest and meeting-service version bump to 0.5.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This client is not actually authenticated-to by v1-sync-helper, but that service, which impersonates authenticated users via its own Heimdall-JWT generation, may use this client ID as the authenticated principal in a bearer token if there is no relevant principal to impersonate for a given data update. Also update Chart dependencies and bump chart version. Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
d46bdf0 to
9b75fcd
Compare
This client is not actually authenticated-to by v1-sync-helper, but that service, which impersonates authenticated users via its own Heimdall-JWT generation, may use this client ID as the authenticated principal in a bearer token if there is no relevant principal to impersonate for a given data update.
Also update Chart dependencies and bump chart version.