Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] make job descriptor JSON5 compatible #138

Open
mimir-d opened this issue Aug 22, 2022 · 3 comments
Open

[v2] make job descriptor JSON5 compatible #138

mimir-d opened this issue Aug 22, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers v2_overhaul breaking feature for v2

Comments

@mimir-d
Copy link
Member

mimir-d commented Aug 22, 2022

Current state: the serialization/deserialization of JSON is done with the golang "encoding/json" package which only understands the standard ECMA flavor.
It has proven useful to have comments in the input descriptors, so we should use a format that supports that.

@mimir-d mimir-d added enhancement New feature or request good first issue Good for newcomers v2_overhaul breaking feature for v2 labels Aug 22, 2022
@xaionaro
Copy link
Member

xaionaro commented Aug 22, 2022

Current state: the serialization/deserialization of JSON is done with the golang "encoding/json" package which only understands the standard ECMA flavor.

IIRC, we had a consensus (in old discussions with @insomniacslk) to use YAML. It is human-readable, supports comments and is a superset for JSON.

@mimir-d
Copy link
Member Author

mimir-d commented Aug 23, 2022

well, we have both. And we can't just remove support for json now. This would at least get some parity.

@xaionaro
Copy link
Member

We do not need the support of JSON, since it is a subset of YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers v2_overhaul breaking feature for v2
Projects
None yet
Development

No branches or pull requests

2 participants