Skip to content

Commit 58729f1

Browse files
committed
src: fix up after botched merge conflict
Mea culpa, I didn't properly resolve a merge conflict in the last two commits. The resulting segmentation fault only happened on Linux and only sometimes. Fixes nodejs#6306.
1 parent f649626 commit 58729f1

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎src/node.cc‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3284,13 +3284,12 @@ Environment* CreateEnvironment(Isolate* isolate,
32843284
// a prepare or check watcher after us, any samples attributed to its callback
32853285
// will be recorded with state=IDLE.
32863286
uv_prepare_init(env->event_loop(), env->idle_prepare_handle());
3287-
uv_prepare_start(env->idle_prepare_handle(), SetIdle);
3287+
uv_check_init(env->event_loop(), env->idle_check_handle());
32883288
uv_unref(reinterpret_cast<uv_handle_t*>(env->idle_prepare_handle()));
32893289
uv_unref(reinterpret_cast<uv_handle_t*>(env->idle_check_handle()));
32903290

32913291
if (v8_is_profiling) {
3292-
uv_check_init(env->event_loop(), env->idle_check_handle());
3293-
uv_check_start(env->idle_check_handle(), ClearIdle);
3292+
StartProfilerIdleNotifier(env);
32943293
}
32953294

32963295
Local<FunctionTemplate> process_template = FunctionTemplate::New();

0 commit comments

Comments
 (0)