Skip to content

Commit 2628b35

Browse files
yaskerNicholas Bellinger
authored andcommitted
tcm_loop: Show address of tpg in configfs
In the past, the scsi_host's number wasn't shown anywhere, user have to depends on vpg_83 to find the block device, which is also depends on backstore implementation. It's better for tcm_loop to provide necessary straightforward information on locate the block device it created. This patch would help to locate the block device created by tcm_loop. The address would be shown at e.g. /sys/kernel/config/target/loopback/naa.60014059436855c1/tpgt_1/address which would looks like "2:0:1", and the lun number can be found at "/tpgt_1/lun/lun_0". Altogether they formated the scsi address of device as "2:0:1:0", which can be used to locate the device easily through 'lsscsi'. (Update to >= v4.4-rc1 configfs attribute usage - nab) Signed-off-by: Sheng Yang <sheng@yasker.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
1 parent 1ec2183 commit 2628b35

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

drivers/target/loopback/tcm_loop.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,12 +1036,26 @@ static ssize_t tcm_loop_tpg_transport_status_store(struct config_item *item,
10361036
return -EINVAL;
10371037
}
10381038

1039+
static ssize_t tcm_loop_tpg_address_show(struct config_item *item,
1040+
char *page)
1041+
{
1042+
struct se_portal_group *se_tpg = to_tpg(item);
1043+
struct tcm_loop_tpg *tl_tpg = container_of(se_tpg,
1044+
struct tcm_loop_tpg, tl_se_tpg);
1045+
struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
1046+
1047+
return snprintf(page, PAGE_SIZE, "%d:0:%d\n",
1048+
tl_hba->sh->host_no, tl_tpg->tl_tpgt);
1049+
}
1050+
10391051
CONFIGFS_ATTR(tcm_loop_tpg_, nexus);
10401052
CONFIGFS_ATTR(tcm_loop_tpg_, transport_status);
1053+
CONFIGFS_ATTR_RO(tcm_loop_tpg_, address);
10411054

10421055
static struct configfs_attribute *tcm_loop_tpg_attrs[] = {
10431056
&tcm_loop_tpg_attr_nexus,
10441057
&tcm_loop_tpg_attr_transport_status,
1058+
&tcm_loop_tpg_attr_address,
10451059
NULL,
10461060
};
10471061

0 commit comments

Comments
 (0)