Skip to content

Commit 90f601b

Browse files
GoodLuck612brauner
authored andcommitted
binfmt_misc: restore write access before closing files opened by open_exec()
bm_register_write() opens an executable file using open_exec(), which internally calls do_open_execat() and denies write access on the file to avoid modification while it is being executed. However, when an error occurs, bm_register_write() closes the file using filp_close() directly. This does not restore the write permission, which may cause subsequent write operations on the same file to fail. Fix this by calling exe_file_allow_write_access() before filp_close() to restore the write permission properly. Fixes: e7850f4 ("binfmt_misc: fix possible deadlock in bm_register_write") Signed-off-by: Zilin Guan <zilin@seu.edu.cn> Link: https://patch.msgid.link/20251105022923.1813587-1-zilin@seu.edu.cn Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent c014021 commit 90f601b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

fs/binfmt_misc.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,8 +837,10 @@ static ssize_t bm_register_write(struct file *file, const char __user *buffer,
837837
inode_unlock(d_inode(root));
838838

839839
if (err) {
840-
if (f)
840+
if (f) {
841+
exe_file_allow_write_access(f);
841842
filp_close(f, NULL);
843+
}
842844
kfree(e);
843845
return err;
844846
}

0 commit comments

Comments
 (0)