soc: aspeed: lpc-snoop: Cleanup resources in stack-order

amboar · amboar · commit 8481d59be606 · 2025-07-02T11:05:20.000+09:30
Free the kfifo after unregistering the miscdev in aspeed_lpc_disable_snoop() as the kfifo is initialised before the miscdev in aspeed_lpc_enable_snoop(). Fixes: 3772e5d ("drivers/misc: Aspeed LPC snoop output using misc chardev") Cc: stable@vger.kernel.org Cc: Jean Delvare <jdelvare@suse.de> Acked-by: Jean Delvare <jdelvare@suse.de> Link: https://patch.msgid.link/20250616-aspeed-lpc-snoop-fixes-v2-1-3cdd59c934d3@codeconstruct.com.au Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -263,8 +263,8 @@ static void aspeed_lpc_disable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
 		return;
 	}
 
-	kfifo_free(&lpc_snoop->chan[channel].fifo);
 	misc_deregister(&lpc_snoop->chan[channel].miscdev);
+	kfifo_free(&lpc_snoop->chan[channel].fifo);
 }
 
 static int aspeed_lpc_snoop_probe(struct platform_device *pdev)

Original file line number	Diff line number	Diff line change
`@@ -263,8 +263,8 @@ static void aspeed_lpc_disable_snoop(struct aspeed_lpc_snoop *lpc_snoop,`
`263`	`263`	`return;`
`264`	`264`	`}`
`265`	`265`
`266`		`- kfifo_free(&lpc_snoop->chan[channel].fifo);`
`267`	`266`	`misc_deregister(&lpc_snoop->chan[channel].miscdev);`
	`267`	`+ kfifo_free(&lpc_snoop->chan[channel].fifo);`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`static int aspeed_lpc_snoop_probe(struct platform_device *pdev)`