firmware_loader: prevent integer overflow in firmware_loading_timeout() #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 0af2f6b |
firmware-kpd
bot
force-pushed
the
driver-core-next_base
branch
2 times, most recently
from
fb12db5 to
877b8a7
Compare
In firmware_loading_timeout(), *int* result of __firmware_loading_timeout() multiplied by HZ might overflow before being implicitly cast to *long* when being returned. Rewrite the function using check_mul_overflow() and capping the result at LONG_MAX on actual overflow... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Cc: stable@vger.kernel.org Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Author
|
Upstream branch: 8f5ae30 |
firmware-kpd
bot
force-pushed
the
series/978825=>driver-core-next
branch
from
ff17967 to
ce72f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: firmware_loader: prevent integer overflow in firmware_loading_timeout()
version: 1
url: https://patchwork.kernel.org/project/firmware/list/?series=978825