net: systemport: fix potential memory leak in bcm_sysport_xmit()

Wang Hai · kuba-moo · commit c401ed1c7099 · 2024-10-15T12:53:52.000-07:00
The bcm_sysport_xmit() returns NETDEV_TX_OK without freeing skb in case of dma_map_single() fails, add dev_kfree_skb() to fix it. Fixes: 80105be ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") Signed-off-by: Wang Hai <wanghai38@huawei.com> Link: https://patch.msgid.link/20241014145115.44977-1-wanghai38@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1359,6 +1359,7 @@ static netdev_tx_t bcm_sysport_xmit(struct sk_buff *skb,
 		netif_err(priv, tx_err, dev, "DMA map failed at %p (len=%d)\n",
 			  skb->data, skb_len);
 		ret = NETDEV_TX_OK;
+		dev_kfree_skb_any(skb);
 		goto out;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1359,6 +1359,7 @@ static netdev_tx_t bcm_sysport_xmit(struct sk_buff *skb,`
`1359`	`1359`	`netif_err(priv, tx_err, dev, "DMA map failed at %p (len=%d)\n",`
`1360`	`1360`	`skb->data, skb_len);`
`1361`	`1361`	`ret = NETDEV_TX_OK;`
	`1362`	`+ dev_kfree_skb_any(skb);`
`1362`	`1363`	`goto out;`
`1363`	`1364`	`}`
`1364`	`1365`