Skip to content

Commit c186b7a

Browse files
Wang Haikuba-moo
authored andcommitted
net: ethernet: rtsn: fix potential memory leak in rtsn_start_xmit()
The rtsn_start_xmit() returns NETDEV_TX_OK without freeing skb in case of skb->len being too long, add dev_kfree_skb_any() to fix it. Fixes: b0d3969 ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") Signed-off-by: Wang Hai <wanghai38@huawei.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20241014144250.38802-1-wanghai38@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 99714e3 commit c186b7a

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/renesas

1 file changed

+1
-0
lines changed

drivers/net/ethernet/renesas/rtsn.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1057,6 +1057,7 @@ static netdev_tx_t rtsn_start_xmit(struct sk_buff *skb, struct net_device *ndev)
10571057
if (skb->len >= TX_DS) {
10581058
priv->stats.tx_dropped++;
10591059
priv->stats.tx_errors++;
1060+
dev_kfree_skb_any(skb);
10601061
goto out;
10611062
}
10621063

0 commit comments

Comments
 (0)