Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking with CAN-J1939 support - documentation networking/j1939.rst #174

Closed
josemic opened this issue Nov 27, 2019 · 1 comment
Closed

Comments

@josemic
Copy link
Contributor

josemic commented Nov 27, 2019

This is a follow-up issue of #159.
networking/j1939.rst
referes to J1939_PGN_ADDRESS_REQUEST, however "j1939.h" defines only:
#define J1939_PGN_REQUEST 0x0ea00

There was once a patch changing the define "J1939_PGN_REQUEST" to "J1939_PGN_ADDRESS_REQUEST". However this patch had been rejected. Still the documentation networking/j1939.rst had been written as if this patch had been applied:
Link to patch

This networking/j1939.rst needs to be changed as following (search for "J1939_PGN_ADDRESS_COMMANDED", add the line marked below with "+" and remove the line marked below with "-"):

const struct j1939_filter filt[] = {
        {
                .pgn = J1939_PGN_ADDRESS_CLAIMED,
                .pgn_mask = J1939_PGN_PDU1_MAX,
        }, {
-                .pgn = J1939_PGN_ADDRESS_REQUEST,
+                .pgn = J1939_PGN_REQUEST,
                .pgn_mask = J1939_PGN_PDU1_MAX,
        }, {
                .pgn = J1939_PGN_ADDRESS_COMMANDED,
                .pgn_mask = J1939_PGN_MAX,
        },
};
@josemic josemic changed the title Networking with CAN-J1939 support (Ubuntu Linux) documentation networking/j1939.rst Networking with CAN-J1939 support documentation networking/j1939.rst Nov 27, 2019
@josemic josemic changed the title Networking with CAN-J1939 support documentation networking/j1939.rst Networking with CAN-J1939 support - documentation networking/j1939.rst Nov 27, 2019
@marckleinebudde
Copy link
Member

I'll include this fix in my next pull request to net/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants