Upgrades to latest version of @ember-template-lint/todo-utils with fuzzy matching (#213)

* chore: Upgrades @ember-template-lint/todo-utils to latest version w/fuzzy matching

Author: scalvert

.eslintrc

@@ -49,11 +49,12 @@
       },
       "rules": {
         "node/no-extraneous-import": "off",
-        "node/no-unpublished-import": "off"
+        "node/no-unpublished-import": "off",
+        "@typescript-eslint/no-non-null-assertion": "off"
       }
     },
     {
-    "files": ["src/types/index.ts"],
+      "files": ["src/types/index.ts"],
       "rules": {
         "@typescript-eslint/no-namespace": "off"
       }

.github/workflows/ci-build.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [ubuntu-latest]
         node: ['12']
 
     steps:

__tests__/__fixtures__/with-errors-for-fuzzy.js

@@ -0,0 +1,12 @@
+
+
+
+function addOne(i) {
+
+  if (i != NaN) {
+
+    return i++;
+  }
+
+  return;
+}

__tests__/__utils__/fake-project.ts

@@ -1,7 +1,13 @@
-import { TodoConfig } from '@ember-template-lint/todo-utils';
-import { execSync } from 'child_process';
+import {
+  DaysToDecay,
+  DaysToDecayByRule,
+  LintTodoPackageJson,
+  TodoConfigByEngine,
+} from '@ember-template-lint/todo-utils';
+import { dirname, join } from 'path';
 import fixturify from 'fixturify';
 import Project from 'fixturify-project';
+import { mkdirpSync, symlinkSync } from 'fs-extra';
 
 const DEFAULT_ESLINT_CONFIG = `{
   "env": {
@@ -67,7 +73,7 @@ export class FakeProject extends Project {
   static getInstance(): FakeProject {
     const project = new this();
 
-    project.addDevDependency('eslint', '^7.10.0');
+    // project.addDevDependency('eslint', '^7.10.0');
 
     project.files['eslint-config.json'] = DEFAULT_ESLINT_CONFIG;
 
@@ -82,30 +88,83 @@ export class FakeProject extends Project {
       description: 'Fake project',
       repository: 'http://fakerepo.com',
     });
+
+    // link binary
+    this.symlink(
+      join(__dirname, '../..', 'node_modules', '.bin', 'eslint'),
+      join(this.baseDir, 'node_modules', '.bin', 'eslint')
+    );
+
+    // link package
+    this.symlink(
+      join(__dirname, '../..', 'node_modules', 'eslint'),
+      join(this.baseDir, 'node_modules', 'eslint')
+    );
   }
 
   write(dirJSON: fixturify.DirJSON): void {
     Object.assign(this.files, dirJSON);
     this.writeSync();
   }
 
-  writeTodoConfig(todoConfig: TodoConfig): void {
+  setShorthandPackageJsonTodoConfig(daysToDecay: DaysToDecay): void {
     this.pkg = Object.assign({}, this.pkg, {
       lintTodo: {
-        daysToDecay: todoConfig,
+        daysToDecay,
       },
     });
 
     this.writeSync();
   }
 
-  install(): void {
-    const cmd = 'yarn install --silent';
+  setPackageJsonTodoConfig(
+    daysToDecay: DaysToDecay,
+    daysToDecayByRule?: DaysToDecayByRule
+  ): void {
+    const todoConfig: LintTodoPackageJson = {
+      lintTodo: {
+        eslint: {
+          daysToDecay,
+        },
+      },
+    };
+
+    if (daysToDecayByRule) {
+      (<TodoConfigByEngine>todoConfig.lintTodo)!['eslint'].daysToDecayByRule =
+        daysToDecayByRule;
+    }
+
+    this.pkg = Object.assign({}, this.pkg, todoConfig);
+
+    this.writeSync();
+  }
+
+  setLintTodorc(
+    daysToDecay: DaysToDecay,
+    daysToDecayByRule?: DaysToDecayByRule
+  ): void {
+    const todoConfig: TodoConfigByEngine = {
+      eslint: {
+        daysToDecay,
+      },
+    };
 
-    try {
-      execSync(cmd, { cwd: this.baseDir });
-    } catch {
-      throw new Error(`Couldn't install dependencies using ${cmd}`);
+    if (daysToDecayByRule) {
+      todoConfig['eslint'].daysToDecayByRule = daysToDecayByRule;
     }
+
+    this.write({
+      '.lint-todorc.js': `module.exports = ${JSON.stringify(
+        todoConfig,
+        // eslint-disable-next-line unicorn/no-null
+        null,
+        2
+      )}`,
+    });
+  }
+
+  symlink(source: string, target: string): void {
+    mkdirpSync(dirname(target));
+    symlinkSync(source, target);
   }
 }

__tests__/__utils__/get-fixture.ts

@@ -1,7 +1,6 @@
 import { join, resolve } from 'path';
 import { ESLint } from 'eslint';
 import { readFileSync, readJsonSync } from 'fs-extra';
-import { TemplateLintResult } from '@ember-template-lint/todo-utils';
 
 const cache: Map<string, string> = new Map();
 
@@ -22,9 +21,10 @@ export function getStringFixture(fileName: string): string {
   return contents;
 }
 
-export function getObjectFixture<
-  T extends ESLint.LintResult | TemplateLintResult
->(fileName: string, tmp: string): T[] {
+export function getObjectFixture<T extends ESLint.LintResult>(
+  fileName: string,
+  tmp: string
+): T[] {
   const fixture = readJsonSync(
     resolve(join('./__tests__/__fixtures__/', fileName))
   );