Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integration test domains #1763

Merged
merged 16 commits into from
Oct 22, 2024
Merged

feat: Integration test domains #1763

merged 16 commits into from
Oct 22, 2024

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Oct 17, 2024

This PR implements integration testing with valid domains and certificates.

  • Reworked the integration test flow
  • Created python script to create and delete A records in Edgedns
  • Removed cluster_persistence and generate_password inputs
  • Renamed Otomi to APL
  • Added tag to be used by the cleanup script: https://bits.linode.com/APL/apl-gh-actions/pull/2

@Ani1357 Ani1357 changed the title Integration test domains feat: Integration test domains Oct 17, 2024
ElderMatt
ElderMatt approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it. I can see that cluster gets created and deleted.

@ferruhcihan ferruhcihan self-requested a review October 21, 2024 12:37
ferruhcihan
ferruhcihan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it.

@Ani1357 Ani1357 merged commit b64c334 into main Oct 22, 2024
5 checks passed
@Ani1357 Ani1357 deleted the integration_test_domains branch October 22, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderMatt ElderMatt ElderMatt approved these changes

@ferruhcihan ferruhcihan ferruhcihan approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ani1357 @ElderMatt @ferruhcihan