Use proper C++ naming conventions for range types #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #77
- Replace SByte with Int8 (std::int8_t) - Replace Byte with UInt8 (std::uint8_t) - Replace Single with Float (std::float_t) - Keep Double as is (std::double_t) This resolves the issue where SByte was unclear - it was a .NET naming convention that doesn't belong in C++. The new names follow standard C++ integer type naming patterns and are more descriptive. Fixes #77 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
This PR addresses issue #77 by replacing .NET-style naming conventions with proper C++ naming in the Range.h file.
🔄 Changes Made
SByte→Int8: Changed to follow standard C++ signed 8-bit integer namingByte→UInt8: Changed to follow standard C++ unsigned 8-bit integer namingSingle→Float: Changed to use more standard C++ float namingDouble: Kept as is (already proper C++ naming)🤔 Rationale
The original
SBytename was unclear and followed .NET/C# naming conventions rather than C++ conventions. As noted in the issue, "SByte (Super Byte)" was confusing - it actually represents a signed 8-bit integer (std::int8_t).The new naming:
Int8/UInt8: Clear, follows standard integer type naming patternsFloat: More common in C++ than "Single"Int16,Int32,Int64,UInt16,UInt32,UInt64names✅ Testing
📚 References
Fixes #77
🤖 Generated with Claude Code