Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should set the gateway from the ip (CIDR) if the user don't provide the gateway. #40

Closed
hwchiu opened this issue Jun 12, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@hwchiu
Copy link
Contributor

hwchiu commented Jun 12, 2018

For the server side, we should calculate the gateway from the IP (CIDR) and use it as the gateway if user don't provide the Gateway.

For the client side, we only accept the following combination

  1. valid IP + valid Gateway
  2. valid IP + empty Gateway
  3. empty IP + empty Gateway (Won't set ip address in this case)
@hwchiu hwchiu added the enhancement New feature or request label Jun 12, 2018
@hwchiu
Copy link
Contributor Author

hwchiu commented Jun 12, 2018

The gateway should only exist if we want the user set the static route.
The combination will be

  1. empty IP + empty static-route
  2. valid IP
  3. valid IP + valid static-rotue

A static-route is CIDR+IP

@John-Lin
Copy link
Contributor

#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants