feat(multicluster): have linkerd-multicluster chart be responsible for service mirror controllers - probes #13781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-probes
branch
from
9c4397d to
dbadec1
Compare
alpeb
added a commit
that referenced
this pull request
Mar 12, 2025
…r service mirror controllers - CLI Followup to #13770 and #13781, based off of branch `alpeb/multicluster-chart-manage-smc-probes` Addresses CLI tasks listed in #13768 - Refers in `multicluster/cmd/install.go` the new templates added in #13770, allowing `linkerd mc install` to also install the model that was implemented in #13770 just for helm. - Adds a new flag `linkerd mc link --service-mirror`; if `false` then it only outputs the Link CR and the credentials secret. The default is `true` so the new model is opt-in. - Refactors `linkerd mc check` in order to check for resources from both the old and new models.
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-probes
branch
from
dbadec1 to
942fffb
Compare
alpeb
added a commit
that referenced
this pull request
Mar 13, 2025
…r service mirror controllers - CLI Followup to #13770 and #13781, based off of branch `alpeb/multicluster-chart-manage-smc-probes` Addresses CLI tasks listed in #13768 - Refers in `multicluster/cmd/install.go` the new templates added in #13770, allowing `linkerd mc install` to also install the model that was implemented in #13770 just for helm. - Adds a new flag `linkerd mc link --service-mirror`; if `false` then it only outputs the Link CR and the credentials secret. The default is `true` so the new model is opt-in. - Refactors `linkerd mc check` in order to check for resources from both the old and new models.
adleong
approved these changes
Mar 13, 2025
alpeb
added a commit
that referenced
this pull request
Mar 14, 2025
…r service mirror controllers - tests Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
alpeb
added a commit
that referenced
this pull request
Mar 14, 2025
…r service mirror controllers - tests Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
alpeb
added a commit
that referenced
this pull request
Mar 14, 2025
…r service mirror controllers - tests Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
…r service mirror controllers - probes Followup to #13770, based off of branch `alpeb/multicluster-chart-manage-smc` #13770 properly sets up the linkerd-multicluster chart to manage controllers, but the probes are still looking for the old `probe-gateway-<clusterName>` service. This change updates `cluster_watcher.go` to have that name be a parameter, that is passed as a controller argument. Likewise, the `linkerd mc gateways` command has been updated to select over old and new controllers.
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-probes
branch
from
942fffb to
b7bf828
Compare
alpeb
added a commit
that referenced
this pull request
Mar 17, 2025
…r service mirror controllers - CLI Followup to #13770 and #13781, based off of branch `alpeb/multicluster-chart-manage-smc-probes` Addresses CLI tasks listed in #13768 - Refers in `multicluster/cmd/install.go` the new templates added in #13770, allowing `linkerd mc install` to also install the model that was implemented in #13770 just for helm. - Adds a new flag `linkerd mc link --service-mirror`; if `false` then it only outputs the Link CR and the credentials secret. The default is `true` so the new model is opt-in. - Refactors `linkerd mc check` in order to check for resources from both the old and new models.
alpeb
added a commit
that referenced
this pull request
Mar 17, 2025
…r service mirror controllers - CLI (#13782) Followup to #13770 and #13781, based off of branch `alpeb/multicluster-chart-manage-smc-probes` Addresses CLI tasks listed in #13768 - Refers in `multicluster/cmd/install.go` the new templates added in #13770, allowing `linkerd mc install` to also install the model that was implemented in #13770 just for helm. - Adds a new flag `linkerd mc link --service-mirror`; if `false` then it only outputs the Link CR and the credentials secret. The default is `true` so the new model is opt-in. - Refactors `linkerd mc check` in order to check for resources from both the old and new models. - Extend the image registry overriding logic to cover the new controllers as well.
alpeb
added a commit
that referenced
this pull request
Mar 17, 2025
…r service mirror controllers - tests Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
alpeb
added a commit
that referenced
this pull request
Mar 17, 2025
…r service mirror controllers - tests (#13800) Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #13770, based off of branch
alpeb/multicluster-chart-manage-smcThird task of #13768
#13770 properly sets up the linkerd-multicluster chart to manage controllers, but the probes are still looking for the old
probe-gateway-<clusterName>service.This change updates
cluster_watcher.goto have that name be a parameter, that is passed as a controller argument.Likewise, the
linkerd mc gatewayscommand has been updated to select over old and new controllers.