chore(deps): address RUSTSEC-2025-0014 #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
commented
Mar 12, 2025
Comment on lines
-213
to
215
| #[inline] | ||
| fn now() -> humantime::Rfc3339Timestamp { | ||
| humantime::format_rfc3339(SystemTime::now()) | ||
| fn now() -> String { | ||
| jiff::Timestamp::now().to_string() | ||
| } |
Member
Author
There was a problem hiding this comment.
this commit replaces `humantime`, which is no longer maintained, with `jiff`. see this error when `main` today is built: ``` error[unmaintained]: humantime is unmaintained ┌─ /linkerd/linkerd2-proxy/Cargo.lock:78:1 │ 78 │ humantime 2.1.0 registry+https://github.com/rust-lang/crates.io-index │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected │ ├ ID: RUSTSEC-2025-0014 ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0014 ├ Latest `humantime` crates.io release is four years old and GitHub repository has not seen commits in four years. Question about maintenance status has not gotten any reaction from maintainer: chronotope/humantime#31 ## Possible alternatives * [jiff](https://crates.io/crates/jiff) provides same kind of functionality ├ Announcement: chronotope/humantime#31 ├ Solution: No safe upgrade is available! ├ humantime v2.1.0 └── linkerd-http-access-log v0.1.0 └── linkerd-app-inbound v0.1.0 ├── linkerd-app v0.1.0 │ ├── linkerd-app-integration v0.1.0 │ └── linkerd2-proxy v0.1.0 ├── linkerd-app-admin v0.1.0 │ ├── linkerd-app v0.1.0 (*) │ └── (dev) linkerd-app-integration v0.1.0 (*) └── linkerd-app-gateway v0.1.0 └── linkerd-app v0.1.0 (*) advisories FAILED, bans ok, licenses ok, sources ok ``` see: * rustsec/advisory-db#2249. * chronotope/humantime#31. Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/rustsec-2025-0014
branch
from
d149cf1 to
2533f7d
Compare
olix0r
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit replaces
humantime, which is no longer maintained, withjiff.see this error when
maintoday is built:see: