Upgrade release-it to latest and fix vm2 vulnerability #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vulnerability *only* exists in the release flow, and this makes sure that we are using a version of release-it which transitively gets what should be a compatible version of `vm2`, and then updates the lock file to resolve at least the version of `vm2` with the fix (3.9.15). We are now safe, since Yarn will never *regress* the resolved lock file version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vulnerability only exists in the release flow, and this makes sure that we are using a version of release-it which transitively gets what should be a compatible version of
vm2, and then updates the lock file to resolve at least the version ofvm2with the fix (3.9.15). We are now safe, since Yarn will never regress the resolved lock file version.