[NPU]:Added support for the layer_norm operator in npu#1113
Open
TianHao324 wants to merge 1 commit intolinkedin:mainfrom
Open
[NPU]:Added support for the layer_norm operator in npu#1113TianHao324 wants to merge 1 commit intolinkedin:mainfrom
TianHao324 wants to merge 1 commit intolinkedin:mainfrom
Conversation
TianHao324
force-pushed
the
layer_npu
branch
from
d860bc4 to
8c96875
Compare
TianHao324
force-pushed
the
layer_npu
branch
from
8c96875 to
0ca405e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added NPU-friendly operator implementations. Previously, only some unsupported writing methods were addressed based on the GPU implementation. However, when the n_col is large, the problem of UB overflow still occurs. This modification has solved this issue, and the performance has improved by 2-3 times compared to the original implementation. However, due to device limitations, the performance is still somewhat lower than that of Hugging Face. We will continue to follow up on the performance issues in the future.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence