Simplified grow logic

linkdotnet · linkdotnet · commit 774468346ba3 · 2022-12-28T10:30:40.000+01:00
diff --git a/stringbuilder.go b/stringbuilder.go
@@ -186,9 +186,9 @@ func (s *StringBuilder) Replace(oldValue string, newValue string) {
 
 func (s *StringBuilder) grow(lenToAdd int) {
 	// Grow times 2 until lenToAdd fits
-	newLen := cap(s.data)
+	newLen := len(s.data)
 
-	if cap(s.data) == 0 {
+	if newLen == 0 {
 		newLen = 8
 	}
 
diff --git a/stringbuilder_benchmark_test.go b/stringbuilder_benchmark_test.go
@@ -5,7 +5,7 @@ import (
 	"testing"
 )
 
-const text = "Hello dear World"
+const text = "Hello my dear World."
 const count = 25
 
 var result string

Original file line number	Diff line number	Diff line change
`@@ -186,9 +186,9 @@ func (s *StringBuilder) Replace(oldValue string, newValue string) {`
`186`	`186`
`187`	`187`	`func (s *StringBuilder) grow(lenToAdd int) {`
`188`	`188`	`// Grow times 2 until lenToAdd fits`
`189`		`- newLen := cap(s.data)`
	`189`	`+ newLen := len(s.data)`
`190`	`190`
`191`		`- if cap(s.data) == 0 {`
	`191`	`+ if newLen == 0 {`
`192`	`192`	`newLen = 8`
`193`	`193`	`}`
`194`	`194`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import (`
`5`	`5`	`"testing"`
`6`	`6`	`)`
`7`	`7`
`8`		`-const text = "Hello dear World"`
	`8`	`+const text = "Hello my dear World."`
`9`	`9`	`const count = 25`
`10`	`10`
`11`	`11`	`var result string`