Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support for Staticman comments #8

Open
VincentTam opened this issue Nov 23, 2018 · 5 comments
Open

[Question] Support for Staticman comments #8

VincentTam opened this issue Nov 23, 2018 · 5 comments

Comments

@VincentTam
Copy link

Hi, this is the author of Beautiful Hugo's Staticman nested comment support halogenica/beautifulhugo#222.

Anyone using this theme would be interested in having Staticman?

@lingxz
Copy link
Owner

lingxz commented Nov 24, 2018

Hey, just a heads up, personally I won't merge comments support into the main branch because as mentioned previously I wanted the theme to be quite minimal, but I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

@rootkea
Copy link

rootkea commented Nov 24, 2018

I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

Well, this will work too. Thanks for being open to suggestions. :)

@VincentTam
Copy link
Author

Setting up a separate branch for a new feature will facilitate testing. (git pull origin feature vs git pull origin pull/222/head) Contributors can only propose PR to existing upstream branches. I suggested creating a dev branch as in eduardoboucas/staticman#231 for PR proposals.

@lingxz
Copy link
Owner

lingxz commented Nov 24, 2018

yes, I'm just saying I won't merge it, but we can leave it in a separate branch. There's no need for a dev branch for now, you can just raise PR against master.

@VincentTam
Copy link
Author

I'll try two weeks later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants