Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): sideEffects to false for shrinking bundle size #1129

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Sep 6, 2021

No description provided.

@vercel
Copy link

vercel bot commented Sep 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/3bQWSGCrqqoqhKfarCAYKrQLHFxj
✅ Preview: https://js-lingui-git-semoal-fix-1124-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1129 (16c18ed) into main (3b449b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files          56       56           
  Lines        1677     1677           
  Branches      459      459           
=======================================
  Hits         1380     1380           
  Misses        173      173           
  Partials      124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b449b7...16c18ed. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.78 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 92.03 KB (0%)

@semoal semoal changed the title fix(): sideEffects false for shrink bundle size a bit fix(): sideEffects to false for shrinking bundle size Sep 6, 2021
@semoal semoal merged commit 57cd2e5 into main Sep 6, 2021
@semoal semoal deleted the semoal/fix-1124 branch September 6, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant