fix: macro components should omit key prop #994

lingui · Mar 4, 2021 · f2a4da0 · f2a4da0 · vercel · Mar 4, 2021
1 parent 60293c8
commit f2a4da0
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/packages/macro/src/macroJsx.test.ts b/packages/macro/src/macroJsx.test.ts
@@ -139,6 +139,34 @@ describe("jsx macro", () => {
       })
     })
 
+    it("plural with key should be omitted", () => {
+      const macro = createMacro()
+      const exp = parseExpression(
+        `<Plural
+          key='somePLural'
+          value={count}
+          _0='No books'
+          one='# book'
+          other='# books'
+         />`
+      )
+      const tokens = macro.tokenizeChoiceComponent(exp)
+      expect(tokens).toEqual({
+        type: "arg",
+        name: "count",
+        value: expect.objectContaining({
+          name: "count",
+          type: "Identifier",
+        }),
+        format: "plural",
+        options: {
+          "=0": "No books",
+          one: "# book",
+          other: "# books",
+        },
+      })
+    })
+
     it("plural with template literal", () => {
       const macro = createMacro()
       const exp = parseExpression(

diff --git a/packages/macro/src/macroJsx.ts b/packages/macro/src/macroJsx.ts
@@ -273,6 +273,7 @@ export default class MacroJSX {
       ID,
       COMMENT,
       MESSAGE,
+      "key",
       // we remove <Trans /> react props that are not useful for translation
       "render",
       "component",