Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty layout height does not match height with text #433

Open
cmyr opened this issue Mar 26, 2021 · 2 comments
Open

empty layout height does not match height with text #433

cmyr opened this issue Mar 26, 2021 · 2 comments
Labels
bug Something isn't working piet-cairo issue in the cairo backend piet-coregraphics issue in the CoreGraphics backend text

Comments

@cmyr
Copy link
Member

cmyr commented Mar 26, 2021

This is a problem on at least cairo and macOS, and is most obvious on cairo.

@cmyr cmyr added bug Something isn't working text piet-coregraphics issue in the CoreGraphics backend piet-cairo issue in the cairo backend labels Mar 26, 2021
@richard-uk1
Copy link
Collaborator

Driveby comment: I'm sure this is the same in the browser: if you have a <span> with nothing in it, it has height 0 whereas as soon as it has a letter in it the height is 1 line height.

@cmyr
Copy link
Member Author

cmyr commented Jun 7, 2021

Yea, this is really specifically about text boxes; when they're empty we still want to know how tall the text would be if it existed, so that we can correctly size the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working piet-cairo issue in the cairo backend piet-coregraphics issue in the CoreGraphics backend text
Projects
None yet
Development

No branches or pull requests

2 participants