Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to filter directories on GTK file dialogs. #947

Closed
cmyr opened this issue May 16, 2020 · 3 comments · Fixed by #957
Closed

Unable to filter directories on GTK file dialogs. #947

cmyr opened this issue May 16, 2020 · 3 comments · Fixed by #957
Labels
bug does not behave the way it is supposed to shell/gtk concerns the GTK backend

Comments

@cmyr
Copy link
Member

cmyr commented May 16, 2020

This was reported in runebender (linebender/runebender#108); apparently the patch that added file type filtering to gtk (#903?) means we're no longer able to open directories, even with the select_directories option set.

@cmyr cmyr added bug does not behave the way it is supposed to shell/gtk concerns the GTK backend labels May 16, 2020
@luleyleo
Copy link
Collaborator

luleyleo commented May 16, 2020

Selecting directories works perfectly fine when not using allowed_types.

Using allowed_types + select_directories is 'broken' indeed, but I do not think we can do anything about that on our end.

The problem with the combination is that you can only navigate bookmarks, but not 'go into' any directories in the dialog because they are filtered out. But if you have a bookmark that gets you to a folder containing a my_font.ufo directory than that works perfectly fine (it is selectable).

Maybe we should just disable filtering directories for now? (on GTK)

@luleyleo luleyleo changed the title Unable to select directories on GTK? Unable to filter directories on GTK file dialogs. May 16, 2020
@xStrom
Copy link
Member

xStrom commented May 16, 2020

I think the GTK implementation can ignore allowed_types when select_directories is true. This would put it on bar with Windows, where Windows itself will ignore allowed_types in that case.

There is no way (using the standard file dialog without extensions) to filter directories on Windows, so I don't think this is a behavior that druid can provide in a cross-platform way.

@cmyr
Copy link
Member Author

cmyr commented May 17, 2020

That sounds reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug does not behave the way it is supposed to shell/gtk concerns the GTK backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants