Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support open dialogs that aren't modal to a particular window #1771

Open
arifd opened this issue May 11, 2021 · 1 comment
Open

Support open dialogs that aren't modal to a particular window #1771

arifd opened this issue May 11, 2021 · 1 comment
Labels
enhancement adds or requests a new feature shell concerns the shell abstraction

Comments

@arifd
Copy link
Contributor

arifd commented May 11, 2021

Currently, calling druid::commands::SHOW_OPEN_PANEL with a Target that isn't a window, will result in nothing happening, and no warning is produced.

A PR already exists to add a warning, but as per @cmyr, here, global open dialogs should be a thing.

@cmyr cmyr added shell concerns the shell abstraction enhancement adds or requests a new feature labels May 11, 2021
@cmyr
Copy link
Member

cmyr commented May 11, 2021

Some additional notes on this:

Part of why this is complicated is that there's some platform behaviour to consider. On macOS, it is normal to have an application open with no open windows; and even with open windows there is a distinction between a modal open dialog (that is modal to a window, for documents that will be opened in that window) and open dialogs that are scoped to the application level; these are generally used when the result of opening the file will result in a new window.

So on macOS, it should be easy enough to make this change.

I'm less sure about other platforms? In practice this may not really matter. We could just add a flag in the API that indicates whether a given dialog is scoped to the window or the application, and if this isn't meaningful on a given platform we can ignore it.

In any case, before really trying to implement this I would want to have a better understanding of the behaviour of the non-mac platforms, so that we can figure out a design that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement adds or requests a new feature shell concerns the shell abstraction
Projects
None yet
Development

No branches or pull requests

2 participants