Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly disable bitcode #210

Merged
merged 1 commit into from
May 22, 2024
Merged

Explicitly disable bitcode #210

merged 1 commit into from
May 22, 2024
+2 −0

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented May 22, 2024

This fixes #209

The script we are using to create the xcframework is using true as the default value for bit code. We need to pass in the false to disable this behavior.

@onevcat onevcat requested a review from daviscdev May 22, 2024 01:53
daviscdev
daviscdev approved these changes May 22, 2024
View reviewed changes
Copy link

@daviscdev daviscdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@onevcat onevcat merged commit 055d2b4 into master May 22, 2024
13 checks passed
@onevcat onevcat deleted the fix/xcframework-bit-code branch May 22, 2024 02:09
@onevcat onevcat mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviscdev daviscdev daviscdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Urgent: Line SDK Contains Bitcode, Causing App Store Rejection
2 participants
@onevcat @daviscdev