Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about adding to the source compatibility suite? #6

Closed
linqingmo opened this issue Nov 30, 2018 · 3 comments
Closed

How about adding to the source compatibility suite? #6

linqingmo opened this issue Nov 30, 2018 · 3 comments
Labels
won't fix This will not be worked on

Comments

@linqingmo
Copy link

Swift 5.0 regression. SR-9375

@onevcat
Copy link
Member

onevcat commented Nov 30, 2018

Thanks for reporting it.

Obviously, it turns to be a Swift 5.0 regression.

I will try to confirm it in the snapshot toolkit later, and send a PR to source compatibility repo to contain it to the regression test suite if necessary.

@onevcat
Copy link
Member

onevcat commented Dec 3, 2018

We made a small workaround to make it compile for Swift development toolchain snapshot you mentioned. However, we are still seeing some crash in our unit tests when we use the snapshot version. And the same issue is happening in the sample app. So I guess it is not a good time to use this framework with that Swift compiler since we didn't have a good time to run full tests for it.

A pull request to Swift Source Compatibility repo was made: swiftlang/swift-source-compat-suite#295

There is little we can do now for this issue anymore. So I am closing it now.

@onevcat onevcat closed this as completed Dec 3, 2018
@onevcat onevcat added the won't fix This will not be worked on label Dec 6, 2018
@onevcat
Copy link
Member

onevcat commented Jan 7, 2019

This issue should be already fixed in Swift: swiftlang/swift#21296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants