Skip to content

Update Node.js version requirement to v20.10 or later #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Node.js version requirement to v20.10 or later #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.ja.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we fully support Node.js v20? If this just wants to read the version, we could create a version.ts instead of relying on package.json. The version can be updated with scripts, so we can update version.ts at the same time. This is simple (and exactly the same approach used by line-bot-sdk-nodejs, with very low maintenance costs).

The advantage of this approach is that it eliminates behavior dependent on the Node.js version and also supports v20.x.y below v20.10. This should be beneficial for users as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree totally.
I'll close this PR and open new PR handling it.
#61

Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ LINE公式アカウントとAI Agentを接続するために、LINE Messaging AP
## インストール (npxを使用)

要件:
- Node.js v20 以上
- Node.js v20.10 以上

### Step 1: LINE公式アカウントを作成

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
## Installation (Using npx)

requirements:
- Node.js v20 or later
- Node.js v20.10 or later

### Step 1: Create LINE Official Account

Expand Down
Loading