use temp directory as destination directory for copy command #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AkihiroSuda merged 1 commit into lima-vm:master from olamilekan000:use-temp-directory-for-test

Feb 4, 2025

Contributor

olamilekan000 commented Jan 27, 2025 •

edited

Loading

Change switches local tests from using $HOME/lima-hostname to a 
temporary directory to prevent conflicts with user-created files 
and permission errors when writing to it.

Fixes #3162

olamilekan000 mentioned this pull request

add rsync flag option to copy files using rsync #3143

Open

AkihiroSuda reviewed

View reviewed changes

hack/test-templates.sh Outdated Show resolved Hide resolved

olamilekan000 force-pushed the use-temp-directory-for-test branch from ac3d2da to a9bd54b Compare

January 28, 2025 15:07

olamilekan000 requested a review from AkihiroSuda

January 28, 2025 15:09

nirs reviewed

View reviewed changes

hack/test-templates.sh Outdated Show resolved Hide resolved

olamilekan000 force-pushed the use-temp-directory-for-test branch from a9bd54b to 7c73d05 Compare

January 28, 2025 19:28

olamilekan000 requested a review from nirs

January 28, 2025 19:33

nirs approved these changes

View reviewed changes

AkihiroSuda reviewed

View reviewed changes

hack/test-templates.sh Outdated Show resolved Hide resolved

olamilekan000 force-pushed the use-temp-directory-for-test branch from 7c73d05 to 09a26d0 Compare

January 29, 2025 01:07

olamilekan000 requested a review from AkihiroSuda

January 29, 2025 01:15

AkihiroSuda added this to the v1.1.0 (tentative) milestone

nirs reviewed

View reviewed changes

hack/test-templates.sh Outdated Show resolved Hide resolved

nirs self-requested a review

January 30, 2025 13:31

olamilekan000 force-pushed the use-temp-directory-for-test branch from 09a26d0 to 0cd74d9 Compare

January 30, 2025 18:25

nirs approved these changes

View reviewed changes

nirs reviewed

View reviewed changes

hack/test-templates.sh Outdated Show resolved Hide resolved


          use temp directory as destination directory for copy command

eaca44e

Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>

olamilekan000 force-pushed the use-temp-directory-for-test branch from 0cd74d9 to eaca44e Compare

February 4, 2025 01:09

AkihiroSuda approved these changes

View reviewed changes

Member

AkihiroSuda left a comment

Thanks

AkihiroSuda merged commit b2467c8 into lima-vm:master

29 checks passed

AkihiroSuda added the area/test label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels