driver(external): clean code and fix driver discovery in libexec

Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>

Author: unsuman

pkg/driver/external/client/client.go

@@ -21,7 +21,6 @@ type DriverClient struct {
 }
 
 func NewDriverClient(socketPath string, logger *logrus.Logger) (*DriverClient, error) {
-	// pipeConn := newPipeConn(stdin, stdout)
 	opts := []grpc.DialOption{
 		grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(16 << 20)),
 		grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(16 << 20)),
@@ -31,14 +30,6 @@ func NewDriverClient(socketPath string, logger *logrus.Logger) (*DriverClient, e
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	}
 
-	// conn, err := grpc.NewClient("pipe", opts...)
-	// if err != nil {
-	// 	logger.Errorf("failed to create gRPC driver client connection: %v", err)
-	// 	return nil, err
-	// }
-	// -> ERRO[2025-06-04T21:32:54+05:30] Failed to set config: rpc error: code =
-	// Unavailable desc = name resolver error: produced zero addresses
-
 	conn, err := grpc.Dial("unix://"+socketPath, opts...)
 	if err != nil {
 		logger.Errorf("failed to dial gRPC driver client connection: %v", err)

pkg/driver/external/client/pipe.go

@@ -4,7 +4,6 @@
 package server
 
 import (
-	"context"
 	"fmt"
 	"net"
 	"os"
@@ -17,7 +16,6 @@ import (
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/keepalive"
 
-	"github.com/lima-vm/lima/pkg/bicopy"
 	"github.com/lima-vm/lima/pkg/driver"
 	pb "github.com/lima-vm/lima/pkg/driver/external"
 )
@@ -31,13 +29,6 @@ type DriverServer struct {
 func Serve(driver driver.Driver) {
 	logger := logrus.New()
 	logger.SetLevel(logrus.DebugLevel)
-	// pipeConn := &PipeConn{
-	// 	Reader: os.Stdin,
-	// 	Writer: os.Stdout,
-	// 	Closer: os.Stdout,
-	// }
-
-	// listener := NewPipeListener(pipeConn)
 
 	socketPath := filepath.Join(os.TempDir(), fmt.Sprintf("lima-driver-%s-%d.sock", driver.GetInfo().DriverName, os.Getpid()))
 
@@ -95,20 +86,3 @@ func Serve(driver driver.Driver) {
 		logger.Fatalf("Failed to serve: %v", err)
 	}
 }
-
-func HandleProxyConnection(ctx context.Context, conn net.Conn, unixSocketPath string) {
-	logrus.Infof("Handling proxy connection from %s", conn.LocalAddr())
-
-	var d net.Dialer
-	unixConn, err := d.DialContext(ctx, "unix", unixSocketPath)
-	if err != nil {
-		logrus.Errorf("Failed to connect to unix socket %s: %v", unixSocketPath, err)
-		return
-	}
-
-	logrus.Infof("Successfully established proxy tunnel: %s <--> %s", conn.LocalAddr(), unixSocketPath)
-
-	go bicopy.Bicopy(unixConn, conn, nil)
-
-	logrus.Infof("Proxy session ended for %s", conn.LocalAddr())
-}

pkg/driver/external/server/pipe.go

@@ -18,7 +18,6 @@ import (
 	"github.com/lima-vm/lima/pkg/driver/external/client"
 	"github.com/lima-vm/lima/pkg/store"
 	"github.com/lima-vm/lima/pkg/store/filenames"
-	"github.com/lima-vm/lima/pkg/usrlocalsharelima"
 	"github.com/sirupsen/logrus"
 )
 
@@ -216,12 +215,13 @@ func (r *Registry) RegisterDriver(name, path string) {
 }
 
 func (r *Registry) DiscoverDrivers() error {
-	limaShareDir, err := usrlocalsharelima.Dir()
+	homeDir, err := os.UserHomeDir()
 	if err != nil {
-		return fmt.Errorf("failed to determine Lima share directory: %w", err)
+		return err
 	}
-	stdDriverDir := filepath.Join(filepath.Dir(limaShareDir), "libexec", "lima", "drivers")
+	stdDriverDir := filepath.Join(homeDir, ".local", "libexec", "lima", "drivers")
 
+	logrus.Infof("Discovering drivers in %s", stdDriverDir)
 	if _, err := os.Stat(stdDriverDir); err == nil {
 		if err := r.discoverDriversInDir(stdDriverDir); err != nil {
 			logrus.Warnf("Error discovering drivers in %s: %v", stdDriverDir, err)

pkg/driver/external/server/server.go

@@ -60,7 +60,6 @@ const (
 	HostAgentStdoutLog      = "ha.stdout.log"
 	HostAgentStderrLog      = "ha.stderr.log"
 	ExternalDriverStderrLog = "driver.stderr.log"
-	ExternalDriverSock      = "driver.sock"
 	VzIdentifier            = "vz-identifier"
 	VzEfi                   = "vz-efi"           // efi variable store
 	QemuEfiCodeFD           = "qemu-efi-code.fd" // efi code; not always created