Merge pull request #3440 from AkihiroSuda/fix-legacyBIOS

AkihiroSuda · web-flow · commit f3cbd68a97d6 · 2025-04-18T10:12:56.000+09:00
ResolveVMType: ignore legacyBIOS on non-Intel
diff --git a/pkg/limayaml/defaults.go b/pkg/limayaml/defaults.go
@@ -1165,8 +1165,8 @@ func ResolveVMType(y, d, o *LimaYAML, filePath string) VMType {
 				logrus.Debugf("ResolveVMType: resolved VMType %q (non-native arch=%q is specified in []*LimaYAML{o,y,d}[%d])", QEMU, *f.Arch, i)
 				return QEMU
 			}
-			if f.Firmware.LegacyBIOS != nil && *f.Firmware.LegacyBIOS {
-				logrus.Debugf("ResolveVMType: resolved VMType %q (firmware.legacyBIOS is specified in []*LimaYAML{o,y,d}[%d])", QEMU, i)
+			if ResolveArch(f.Arch) == X8664 && f.Firmware.LegacyBIOS != nil && *f.Firmware.LegacyBIOS {
+				logrus.Debugf("ResolveVMType: resolved VMType %q (firmware.legacyBIOS is specified in []*LimaYAML{o,y,d}[%d], on x86_64)", QEMU, i)
 				return QEMU
 			}
 			if f.MountType != nil && *f.MountType == NINEP {

Original file line number	Diff line number	Diff line change
`@@ -1165,8 +1165,8 @@ func ResolveVMType(y, d, o *LimaYAML, filePath string) VMType {`
`1165`	`1165`	`logrus.Debugf("ResolveVMType: resolved VMType %q (non-native arch=%q is specified in []LimaYAML{o,y,d}[%d])", QEMU, f.Arch, i)`
`1166`	`1166`	`return QEMU`
`1167`	`1167`	`}`
`1168`		`- if f.Firmware.LegacyBIOS != nil && *f.Firmware.LegacyBIOS {`
`1169`		`- logrus.Debugf("ResolveVMType: resolved VMType %q (firmware.legacyBIOS is specified in []*LimaYAML{o,y,d}[%d])", QEMU, i)`
	`1168`	`+ if ResolveArch(f.Arch) == X8664 && f.Firmware.LegacyBIOS != nil && *f.Firmware.LegacyBIOS {`
	`1169`	`+ logrus.Debugf("ResolveVMType: resolved VMType %q (firmware.legacyBIOS is specified in []*LimaYAML{o,y,d}[%d], on x86_64)", QEMU, i)`
`1170`	`1170`	`return QEMU`
`1171`	`1171`	`}`
`1172`	`1172`	`if f.MountType != nil && *f.MountType == NINEP {`