Skip to content

Commit ed63fb6

Browse files
authored
Include optional params parameter for Commits compare
With the current API, we cannot paginate compare basehead function call. The Github API limits the response to only 250 commits so for larger diffs we have no option.
1 parent 9906308 commit ed63fb6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/Github/Api/Repository/Commits.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ public function all($username, $repository, array $params)
1616
return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/commits', $params);
1717
}
1818

19-
public function compare($username, $repository, $base, $head, $mediaType = null)
19+
public function compare($username, $repository, $base, $head, $mediaType = null, array $params = [])
2020
{
2121
$headers = [];
2222
if (null !== $mediaType) {
2323
$headers['Accept'] = $mediaType;
2424
}
2525

26-
return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/compare/'.rawurlencode($base).'...'.rawurlencode($head), [], $headers);
26+
return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/compare/'.rawurlencode($base).'...'.rawurlencode($head), $params, $headers);
2727
}
2828

2929
public function show($username, $repository, $sha)

0 commit comments

Comments
 (0)