Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build with Go-1.19, 1.19.1 #244

Closed
jmacd opened this issue Aug 5, 2022 · 2 comments · Fixed by #302
Closed

Does not build with Go-1.19, 1.19.1 #244

jmacd opened this issue Aug 5, 2022 · 2 comments · Fixed by #302

Comments

@jmacd
Copy link
Member

jmacd commented Aug 5, 2022

Describe the bug
See golang/go#54302

To Reproduce
Use Go-1.19 and this code, specifically the lighstep/sdk/metric/aggregator/minmaxsumcount package appears to trigger the compiler and we're yet sure how.

Expected behavior
This should compile, since it did in 1.18.
@jmacd jmacd changed the title Does not build with Go-1.19 Does not build with Go-1.19, 1.19.1 Sep 6, 2022
@jmacd
Copy link
Member Author

jmacd commented Sep 6, 2022

See golang/go#54910

@jmacd
Copy link
Member Author

jmacd commented Sep 19, 2022

gotip at at fc1cddc Revert "runtime: treat SI_TKILL like SI_USER on Linux" builds.

This was referenced Oct 4, 2022
Merged
Merged
@jmacd jmacd closed this as completed in #302 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare release 1.11.1 lightstep/otel-launcher-go
1 participant
@jmacd