Skip to content

Do not record non-sampled spans #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2020
Merged

Do not record non-sampled spans #109

merged 2 commits into from
Sep 18, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 17, 2020

Fixes #108

@ocelotl ocelotl self-assigned this Sep 17, 2020
codeboten
codeboten suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please update the changelog

kayousterhout
kayousterhout approved these changes Sep 18, 2020
View reviewed changes
Copy link

@kayousterhout kayousterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@codeboten codeboten merged commit 2997612 into master Sep 18, 2020
@ikonst
Copy link

ikonst commented Sep 18, 2020

Thanks @ocelotl!

@codeboten codeboten deleted the issue_108 branch June 16, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@kayousterhout kayousterhout kayousterhout approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respecting sampling in recorders
4 participants
@ocelotl @ikonst @codeboten @kayousterhout