-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify close behavior to block until a satellite sends a response #223
Conversation
std::mutex shutdown_mutex_; | ||
std::condition_variable shutdown_condition_variable_; | ||
std::atomic<int> shutdown_counter_{0}; | ||
bool last_is_active_{true}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a bit of trouble following what this variable does. Could you add a comment? Maybe add a comment on ShutdownWithTimeout to explain why it can fail even without a timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment
Fixes #219