Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update release script to allow user to specify systems #2191

Merged
merged 1 commit into from
Dec 18, 2018
Merged

release: update release script to allow user to specify systems #2191

merged 1 commit into from
Dec 18, 2018

Conversation

xsb
Copy link
Contributor

@xsb xsb commented Nov 16, 2018

Whenever there is a new tagged release I find it useful to use release.sh targeting my own architecture. This PR introduces the option to specify a subset of systems/architectures or to try experimental ones without editing it.

Example:

LNDBUILDSYS="linux-arm64 darwin-amd64" ./release.sh

Notice that this is totally optional. When LNDBUILDSYS is unset the script works as always did.

@halseth
Copy link
Contributor

halseth commented Nov 23, 2018

Concept ACK

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour golang/build system Related to the go language and compiler P3 might get fixed, nice to have needs testing PR hasn't yet been actively tested on testnet/mainnet releases labels Nov 27, 2018
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 🎉

@Roasbeef Roasbeef merged commit e028355 into lightningnetwork:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour golang/build system Related to the go language and compiler needs testing PR hasn't yet been actively tested on testnet/mainnet P3 might get fixed, nice to have releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants