Guide assumes testnet, adding a note about mainnet #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This install guide assumes you'll be installing on testnet, which is no bad thing. However, mainnet is now an option, so I've added a note to that effect. I haven't changed the instructions from testnet, because that's trivial to do for most people (and probably shouldn't be attempted by people who can't make that change themselves!).
|
The guide doesn't "assume" testnet. It simply walks users through starting with |
|
Sorry, I used the word 'assumes' for brevity in the commit header. As you say, "It's easy to see via lnd -h that we support many other modes.", yes, it's easy for an expert to know that. As a noob I had no idea. Also, from the document alone, I had no idea that anything other than testnet was supported. I asked on IRC and got better info. For the noobs, some info on this page is warranted I think. My comment is certainly not the best info, but something should be added I think. |
meshcollider
added
the
documentation
|
What was wrong with my proposed patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #751
Thanks to molz on IRC