-
Notifications
You must be signed in to change notification settings - Fork 2.2k
build: update CI+release version to Go 1.25.2 #10285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Roasbeef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the Go language versions utilized throughout the project's build, testing, and deployment infrastructure. The primary goal is to align the project with recent Go releases, ensuring that all components benefit from the latest performance improvements, security patches, and language features. This involves updating the Go version specified in CI workflows, Docker images, and Go module definitions, as well as updating installation instructions in the documentation. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Go version used for CI and release builds to 1.25.2, and pins the Go module version to 1.24.8. The changes are consistent and applied correctly across all relevant files, including Dockerfiles, Makefiles, CI configuration, and module files. I've added a couple of suggestions to improve the installation instructions in docs/INSTALL.md to make the checksum verification more robust for users.
bhandras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
guggero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise LGTM 🎉
docs/INSTALL.md
Outdated
|
|
||
| The final output of the command above should be | ||
| `bbca37cc395c974ffa4893ee35819ad23ebb27426df87af92e93a9ec66ef8712`. If it | ||
| `da18191ddb7db8a9339816f3e2b54bdded8047cdc2a5d67059478f8d1595c43f`. If it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this and the hash below are for v1.24.7. For v1.24.8 it's 6842c516ca66c89d648a7f1dbe28e28c47b61b59f8f06633eb2ceb1188e9251d (linux-amd64) and 3ed8537300ab22449885a43d2931336a571df72c5433d2db4377fe7e2d5e83db (linux-armv6l) respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, actually just fixed this locally. Thanks for helping to verify!
We also update the go.mod files to pin to Go 1.24.8.
We also update the go.mod files to pin to Go 1.24.8.