Skip to content

Conversation

@Roasbeef
Copy link
Member

We also update the go.mod files to pin to Go 1.24.8.

@Roasbeef Roasbeef requested a review from a team October 10, 2025 11:40
@Roasbeef Roasbeef requested review from bhandras and guggero and removed request for a team and guggero October 10, 2025 11:40
@gemini-code-assist
Copy link

Summary of Changes

Hello @Roasbeef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically updates the Go language versions utilized throughout the project's build, testing, and deployment infrastructure. The primary goal is to align the project with recent Go releases, ensuring that all components benefit from the latest performance improvements, security patches, and language features. This involves updating the Go version specified in CI workflows, Docker images, and Go module definitions, as well as updating installation instructions in the documentation.

Highlights

  • Go Version Update for CI and Docker: The Go version used across various CI configurations, Dockerfiles, and build scripts has been updated from 1.24.6 to 1.25.2 to leverage the latest stable Go release for development and deployment environments.
  • Go Module Version Pinning: All go.mod files within the project and its submodules have been updated to explicitly pin the required Go version to 1.24.8. This ensures consistency in module resolution and build environments.
  • Documentation Update: The docs/INSTALL.md file has been revised to reflect the new minimum Go version of 1.24.8 and includes updated download links and SHA256 checksums for installing Go on Linux (x86-64 and ARMv6).
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/main.yml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version used for CI and release builds to 1.25.2, and pins the Go module version to 1.24.8. The changes are consistent and applied correctly across all relevant files, including Dockerfiles, Makefiles, CI configuration, and module files. I've added a couple of suggestions to improve the installation instructions in docs/INSTALL.md to make the checksum verification more robust for users.

Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM 🎉

docs/INSTALL.md Outdated

The final output of the command above should be
`bbca37cc395c974ffa4893ee35819ad23ebb27426df87af92e93a9ec66ef8712`. If it
`da18191ddb7db8a9339816f3e2b54bdded8047cdc2a5d67059478f8d1595c43f`. If it
Copy link
Collaborator

@guggero guggero Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this and the hash below are for v1.24.7. For v1.24.8 it's 6842c516ca66c89d648a7f1dbe28e28c47b61b59f8f06633eb2ceb1188e9251d (linux-amd64) and 3ed8537300ab22449885a43d2931336a571df72c5433d2db4377fe7e2d5e83db (linux-armv6l) respectively.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, actually just fixed this locally. Thanks for helping to verify!

We also update the go.mod files to pin to Go 1.24.8.
@Roasbeef Roasbeef merged commit 6ade31d into lightningnetwork:master Oct 11, 2025
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants