Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate watchtower client by default #5344

Open
AbelLykens opened this issue May 31, 2021 · 3 comments · May be fixed by #6733
Open

Activate watchtower client by default #5344

AbelLykens opened this issue May 31, 2021 · 3 comments · May be fixed by #6733
Labels
beginner Issues suitable for new developers config Parameters/arguments/config file related issues/PRs enhancement Improvements to existing features / behaviour P2 should be fixed if one has time watchtower

Comments

@AbelLykens
Copy link
Contributor

Background

I think it would be useful if the watchtower client is enabled by default. More people should use watchtowers I feel; but them having to activate wtclient first makes it harder. Why not enable by default?

Your environment

  • version of lnd commit=v0.12.1-beta

Steps to reproduce

People try to connect to watchtower
People get error watchtower not active

Expected behaviour

People try to connect to watchtower
Watchtower connects

Actual behaviour

Well I just said that ;).

@wpaulino wpaulino added config Parameters/arguments/config file related issues/PRs enhancement Improvements to existing features / behaviour watchtower labels Jun 1, 2021
@wpaulino wpaulino added this to the v0.14.0 milestone Jun 1, 2021
@Roasbeef Roasbeef added the beginner Issues suitable for new developers label Jul 1, 2021
@DarthBenro008
Copy link

Hey @Roasbeef @carlaKC , I would like to work on this issue 😃 !

@ellemouton
Copy link
Collaborator

Personally, I dont think we should activate it by default. It would mean that users who dont want to use watchtowers or users who dont even know about them will have backups continue to build up because the user would not know that they need to add the details of a tower to send the updates too. I think it should remain an opt-in feature.

@saubyk
Copy link
Collaborator

saubyk commented Apr 20, 2023

Personally, I dont think we should activate it by default. It would mean that users who dont want to use watchtowers or users who dont even know about them will have backups continue to build up because the user would not know that they need to add the details of a tower to send the updates too. I think it should remain an opt-in feature.

Agreed. Unless there's a possibility that, the backups start building only after the user adds the tower to send the updates to, it wouldn't make sense to activate WT client by default.

@saubyk saubyk removed this from the v0.17.0 milestone Jun 15, 2023
@ellemouton ellemouton removed their assignment Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues suitable for new developers config Parameters/arguments/config file related issues/PRs enhancement Improvements to existing features / behaviour P2 should be fixed if one has time watchtower
Projects
None yet
6 participants