Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect port number in uris of getinfo #4736

Open
Kixunil opened this issue Oct 29, 2020 · 2 comments
Open

Incorrect port number in uris of getinfo #4736

Kixunil opened this issue Oct 29, 2020 · 2 comments
Labels
config Parameters/arguments/config file related issues/PRs discovery Peer and route discovery / whisper protocol related issues/PRs documentation Documentation changes that do not affect code behaviour

Comments

@Kixunil
Copy link
Contributor

Kixunil commented Oct 29, 2020

Background

The port present in uris field returned by getinfo is not the same as set via listen. It's 9735 even if listen contains a different port.

Your environment

  • version of lnd 0.11.1-beta
  • which operating system (uname -a on *Nix) Linux <censored> 4.19.0-10-amd64 #1 SMP Debian 4.19.132-1 (2020-07-24) x86_64 GNU/Linux
  • version of btcd, bitcoind, or other backend Bitcoin Core version v0.20.0
  • any other relevant environment details

Steps to reproduce

  1. setup LND with listen=0.0.0.0:9736 and externalip=YOUR_IP_OR_ONION
  2. run lncli getinfo

Expected behaviour

Returned uris field contains port 9736

Actual behaviour

Returned uris field contains port 9735

@wpaulino
Copy link
Contributor

The two config options aren't linked together at the moment. externalip allows you to set a port as well, so if you're listening on a different port than 9735 externally, you'll need to specify it there as well. We could detect that if externalip doesn't have a port then we use whatever we're listening on if you'd like to propose a PR to do so.

@Kixunil
Copy link
Contributor Author

Kixunil commented Oct 30, 2020

Yeah, that'd be helpful. I don't have much experience with Go, so I can't promise a PR any time soon. I will fix it on my side (which is trivial) for the time being.

@Roasbeef Roasbeef added config Parameters/arguments/config file related issues/PRs discovery Peer and route discovery / whisper protocol related issues/PRs documentation Documentation changes that do not affect code behaviour labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Parameters/arguments/config file related issues/PRs discovery Peer and route discovery / whisper protocol related issues/PRs documentation Documentation changes that do not affect code behaviour
Projects
None yet
Development

No branches or pull requests

3 participants