Skip to content

Commit 655e87c

Browse files
committed
lnd: remove/add todo
In this commit we remove a todo on persisting other node ann fields, and add a todo for persisting the node's features.
1 parent 4719887 commit 655e87c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

server.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -932,11 +932,6 @@ func newServer(ctx context.Context, cfg *Config, listenAddrs []net.Addr,
932932
selfAddrs := make([]net.Addr, 0, len(externalIPs))
933933
selfAddrs = append(selfAddrs, externalIPs...)
934934

935-
// TODO(elle): All previously persisted node announcement fields (ie,
936-
// not just LastUpdate) should be consulted here to ensure that we
937-
// aren't overwriting any fields that may have been set during the
938-
// last run of lnd.
939-
940935
// We now get the self node which represents our node on the channel
941936
// graph.
942937
selfNode, err := s.getSelfNode(
@@ -5622,6 +5617,8 @@ func (s *server) getSelfNode(ctx context.Context, selfAddrs []net.Addr,
56225617
return nil, err
56235618
}
56245619

5620+
// TODO(abdulkbk): potentially find a way to use the source node's
5621+
// features in the self node.
56255622
selfNode := &models.LightningNode{
56265623
HaveNodeAnnouncement: true,
56275624
LastUpdate: nodeLastUpdate,

0 commit comments

Comments
 (0)