Skip to content

Conversation

guggero
Copy link
Contributor

@guggero guggero commented May 1, 2025

Implements the mailbox server and client as described here: #874 (comment)


This change is Reviewable

@guggero guggero requested review from Roasbeef and ffranr May 1, 2025 14:14
@coveralls
Copy link

coveralls commented May 1, 2025

Pull Request Test Coverage Report for Build 15734766059

Details

  • 818 of 1232 (66.4%) changed or added relevant lines in 12 files are covered.
  • 41 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.5%) to 37.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
authmailbox/message.go 3 6 50.0%
internal/test/grpc.go 8 12 66.67%
authmailbox/stream.go 20 26 76.92%
authmailbox/mock.go 41 56 73.21%
internal/test/mock.go 17 55 30.91%
proof/tx.go 106 144 73.61%
authmailbox/client.go 81 127 63.78%
authmailbox/receive_subscription.go 207 271 76.38%
proof/mock.go 0 85 0.0%
authmailbox/server.go 321 436 73.62%
Files with Coverage Reduction New Missed Lines %
asset/mock.go 2 65.45%
tappsbt/create.go 2 26.74%
tapchannel/aux_leaf_signer.go 3 43.43%
tapchannel/aux_invoice_manager.go 6 80.51%
tapgarden/caretaker.go 6 68.68%
address/address.go 8 67.47%
address/mock.go 14 88.24%
Totals Coverage Status
Change from base Build 15712916525: 0.5%
Covered Lines: 28115
Relevant Lines: 74383

💛 - Coveralls

@levmi levmi moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board May 8, 2025
@levmi levmi added the P1 label May 8, 2025
@guggero guggero requested review from Roasbeef and ffranr May 27, 2025 15:33
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @ffranr and @guggero)

@guggero
Copy link
Contributor Author

guggero commented May 28, 2025

I removed the sender's ephemeral key from the proto. It will be part of the encrypted payload, passed into the EncryptSha256ChaCha20Poly1305 function as additionalData.

@lightninglabs-deploy
Copy link

@Roasbeef: review reminder
@ffranr: review reminder

@Roasbeef Roasbeef requested a review from ffranr June 18, 2025 01:18
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦋

Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @ffranr and @guggero)


authmailbox/client.go line 133 at r2 (raw file):

func (c *Client) Stop() error {
	var stopErr error
	c.stopOnce.Do(func() {

👍 for sync.Once.


authmailbox/server.go line 99 at r2 (raw file):

// Start signals that the RPC server starts accepting requests.
func (s *Server) Start() error {
	if !s.started.CompareAndSwap(false, true) {

sync.Once here again to be consistent with the rest of the PR?

guggero added 6 commits June 18, 2025 15:49
To allow re-starting a server with a given listen address, we refactor
some of the code to export a new function to do just that.
TxProof is a struct that holds all components to prove a claimed
outpoint exists in a given block.
@guggero guggero merged commit dace775 into main Jun 18, 2025
35 of 36 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Jun 18, 2025
@guggero guggero deleted the group-key-addr branch June 26, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

6 participants