[group key addrs 1/?]: add new authmailbox RPC server and client #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow re-starting a server with a given listen address, we refactor some of the code to export a new function to do just that.
TxProof is a struct that holds all components to prove a claimed outpoint exists in a given block.
Pull Request Test Coverage Report for Build 14776884033Details
💛 - Coveralls |
ffranr
reviewed
May 7, 2025
| service Mailbox { | ||
| /* | ||
| Sends a single message to a receiver's mailbox. Requires a valid, unused | ||
| Bitcoin transaction outpoint as proof of work/stake. |
| /* | ||
| A simple ping-pong RPC to check the server's health and connectivity. | ||
| */ | ||
| rpc Ping (PingRequest) returns (PingResponse); |
There was a problem hiding this comment.
Maybe consider just calling this GetInfo. I think we have that elsewhere.
Comment on lines
+1
to
+11
| package rpcutils | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "io" | ||
|
|
||
| "github.com/btcsuite/btcd/chaincfg/chainhash" | ||
| "github.com/btcsuite/btcd/wire" | ||
| "github.com/lightninglabs/taproot-assets/proof" | ||
| mboxrpc "github.com/lightninglabs/taproot-assets/taprpc/authmailboxrpc" |
There was a problem hiding this comment.
I think file name here should be more specific to authmailboxrpc. IMO proof.go is too general.
Comment on lines
+185
to
+204
| // TxProof is a struct that contains all the necessary elements to prove the | ||
| // existence of a certain outpoint in a block. | ||
| type TxProof struct { | ||
| // MsgTx is the transaction that contains the outpoint. | ||
| MsgTx wire.MsgTx | ||
|
|
||
| // BlockHeader is the header of the block that contains the transaction. | ||
| BlockHeader wire.BlockHeader | ||
|
|
||
| // BlockHeight is the height at which the block was mined. | ||
| BlockHeight uint32 | ||
|
|
||
| // MerkleProof is the proof that the transaction is included in the | ||
| // block and its merkle root. | ||
| MerkleProof TxMerkleProof | ||
|
|
||
| // ClaimedOutPoint is the outpoint that is being proved to exist in the | ||
| // transaction. | ||
| ClaimedOutPoint wire.OutPoint | ||
| } |
There was a problem hiding this comment.
Anyone can prove an outpoint in a block. The UTXO set is public. Any sender could use up all UTXOs.
Maybe I'm missing something, please see #874 (comment)
|
@guggero, remember to re-request review from reviewers when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the mailbox server and client as described here: #874 (comment)