tapdb: fix aider mistakes and inconsistencies #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13564134447Details
💛 - Coveralls |
Roasbeef
approved these changes
Feb 27, 2025
| require.NoError(t, err) | ||
| require.Equal(t, "issuance", proofType) | ||
|
|
||
| // Check federation_global_sync_config dummy data. | ||
| err = db.QueryRowContext(ctx, | ||
| `SELECT proof_type |
There was a problem hiding this comment.
I think this was actually my inconsistency lol. Got review feedback to limit the line length on the queries, and just kinda hacked away at it until things were in line.
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.