tapdb: expand allowed proof types in universe-related tables #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
ignore-commit
branch
2 times, most recently
from
774947a to
d29ee21
Compare
Pull Request Test Coverage Report for Build 13448911508Details
💛 - Coveralls |
Roasbeef
force-pushed
the
ignore-commit
branch
from
d29ee21 to
c1a40a9
Compare
Roasbeef
force-pushed
the
ignore-commit
branch
from
c1a40a9 to
9be9904
Compare
Roasbeef
requested review from
a team,
ffranr and
GeorgeTsagk
and removed request for
a team
ffranr
reviewed
Feb 19, 2025
Roasbeef
force-pushed
the
ignore-commit
branch
from
9be9904 to
a06c6a2
Compare
GeorgeTsagk
reviewed
Feb 20, 2025
| -- ****************************************************************************************** | ||
|
|
||
| -- For universe_roots | ||
| ALTER TABLE universe_roots ADD COLUMN proof_type TEXT NOT NULL CHECK(proof_type IN ('issuance', 'transfer')); |
There was a problem hiding this comment.
seems like you're using a max line length 100 here, instead of 80
There was a problem hiding this comment.
So I don't think we currently have that rule for SQL queries. Eg: queries/mssmt.sql
This commit introduces a migration that expands the allowed values for the "proof_type" column in the universe-related tables by adding new proof types: "burn" and "ignore". Key changes include: - Creation of a new table `proof_types` to store valid proof type values. Before this commit, we used a `CHECK` statement. With the way sqlite works, we can't _alter_ the `CHECK` statement, and just dropping the row would lose data. So instead, we add a new enum-like table instead. This can be updated in future migrations to add new proof types. We then do a migration to update all tables to use this instead. - Updates to the `universe_roots`, `federation_global_sync_config`, and `federation_uni_sync_config` tables to accommodate the new proof types. This involves adding a new column `proof_type_ext` that references the `proof_types` table, copying existing data, and renaming columns to maintain the original structure. - A new test case `TestMigration29` has been added to ensure the migration works as expected, verifying both the migration of existing data and the insertion of new rows with the new proof types. - The `.gitignore` file has been updated to exclude files matching the pattern `.aider*`. Additionally, a down migration script has been created to revert these changes if necessary. This ensures that the database schema can be rolled back to its previous state without data loss.
Roasbeef
force-pushed
the
ignore-commit
branch
from
a06c6a2 to
9bcff01
Compare
Roasbeef
commented
Feb 21, 2025
| @@ -632,6 +619,10 @@ CREATE TABLE proof_transfer_log ( | |||
| time_unix TIMESTAMP NOT NULL | |||
| ); | |||
|
|
|||
| CREATE TABLE proof_types ( | |||
There was a problem hiding this comment.
Nice part about this is that you can spot check the end result of a migration.
Roasbeef
commented
Feb 21, 2025
| allow_sync_insert BOOLEAN NOT NULL, | ||
|
|
||
| -- This field is a boolean that indicates whether or not the given universe | ||
| -- should accept remote proof export via federation sync. | ||
| allow_sync_export BOOLEAN NOT NULL, | ||
| allow_sync_export BOOLEAN NOT NULL, proof_type TEXT REFERENCES proof_types(proof_type), |
There was a problem hiding this comment.
Not sure why it didn't do a new line here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a migration that expands the allowed values for the "proof_type" column in the universe-related tables by adding new proof types: "burn" and "ignore".
Key changes include:
Creation of a new table
proof_typesto store valid proof type values. Before this commit, we used aCHECKstatement. With the way sqlite works, we can't alter theCHECKstatement, and just dropping the row would lose data.So instead, we add a new enum-like table instead. This can be updated in future migrations to add new proof types. We then do a migration to update all tables to use this instead.
Updates to the
universe_roots,federation_global_sync_config, andfederation_uni_sync_configtables to accommodate the new proof types. This involves adding a new columnproof_type_extthat references theproof_typestable, copying existing data, and renaming columns to maintain the original structure.A new test case
TestMigration29has been added to ensure the migration works as expected, verifying both the migration of existing data and the insertion of new rows with the new proof types.The
.gitignorefile has been updated to exclude files matching the pattern.aider*.Additionally, a down migration script has been created to revert these changes if necessary. This ensures that the database schema can be rolled back to its previous state without data loss.