Expand VerifyOwnershipProof #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10352600053Details
💛 - Coveralls |
guggero
reviewed
Aug 12, 2024
sputn1ck
force-pushed
the
ownershipproof_outpoint
branch
from
e6fddea
to
f5b4d6f
Compare
This commit expands the VerifyAssetOwnership rpc by including the outpoint, block_hash and block_height of the proof
This commit expands VerifyAssetownership by returning the outpoint block hash and blockheight of the proof.
sputn1ck
force-pushed
the
ownershipproof_outpoint
branch
from
f5b4d6f
to
d724a0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands VerifyOwnershipProof by returning the outpoint, block height and blockhash the proof commits to.
This eases asset ownership verification, as clients can check if the outpoint has been spent.